Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make TypedAttribute not generic #3505

Merged
merged 16 commits into from
Nov 22, 2024
Merged

core: make TypedAttribute not generic #3505

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4b08fcd
misc: split dialects.utils into multiple files (#3472)
superlopuh Nov 20, 2024
ee4094f
dialects: (builtin) make FloatAttr a TypedAttribute (#3488)
alexarice Nov 20, 2024
25adb58
dialects: (stream) simplify constr helper on stream attributes (#3473)
superlopuh Nov 20, 2024
afa862d
Revert "dialects: (stream) simplify constr helper on stream attribute…
superlopuh Nov 20, 2024
680b556
dialects: (stream) simplify constr helper on stream attributes (#3494)
superlopuh Nov 20, 2024
f7088a0
dialects: (stream) use assembly format for stream read and write ops …
superlopuh Nov 20, 2024
5603904
dialects: (stream) remove abstract stream read and write operations (…
superlopuh Nov 20, 2024
cffac36
misc: add get helper to ScopedDict (#3499)
superlopuh Nov 22, 2024
4e09b2d
pip prod(deps): bump marimo from 0.9.20 to 0.9.21 (#3502)
dependabot[bot] Nov 22, 2024
150b84b
API: add InferenceContext (#3500)
superlopuh Nov 22, 2024
8d8feaf
core: refactor assembly format directives (#3501)
alexarice Nov 22, 2024
421792a
dialects: (linalg) linalg.fill attribute positioning (#3496)
qaco Nov 22, 2024
020cae7
interpreter: (pdl) add the implementation of type interpretation (#3498)
qaco Nov 22, 2024
f11ca74
core: make TypedAttribute not generic
alexarice Nov 22, 2024
0a23612
Merge branch 'main' into alexarice/typed-attribute-not-generic
alexarice Nov 22, 2024
1dfa2d6
fix floatattr
alexarice Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/irdl/test_attribute_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def test_typed_attribute():

@irdl_attr_definition
class TypedAttr( # pyright: ignore[reportUnusedClass]
TypedAttribute[Attribute]
TypedAttribute
):
name = "test.typed"

Expand Down
6 changes: 3 additions & 3 deletions xdsl/dialects/builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ class IndexType(ParametrizedAttribute):
@irdl_attr_definition
class IntegerAttr(
Generic[_IntegerAttrType],
TypedAttribute[_IntegerAttrType],
TypedAttribute,
):
name = "integer"
value: ParameterDef[IntAttr]
Expand Down Expand Up @@ -504,8 +504,8 @@ def verify(self) -> None:
@staticmethod
def parse_with_type(
parser: AttrParser,
type: AttributeInvT,
) -> TypedAttribute[AttributeInvT]:
type: Attribute,
) -> TypedAttribute:
assert isinstance(type, IntegerType | IndexType)
return IntegerAttr(parser.parse_integer(allow_boolean=(type == i1)), type)

Expand Down
6 changes: 3 additions & 3 deletions xdsl/ir/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def _verify(self):
super()._verify()


class TypedAttribute(ParametrizedAttribute, Generic[AttributeCovT], ABC):
class TypedAttribute(ParametrizedAttribute, ABC):
"""
An attribute with a type.
"""
Expand All @@ -617,8 +617,8 @@ def get_type_index(cls) -> int: ...
@staticmethod
def parse_with_type(
parser: AttrParser,
type: AttributeInvT,
) -> TypedAttribute[AttributeInvT]:
type: Attribute,
) -> TypedAttribute:
"""
Parse the attribute with the given type.
"""
Expand Down
Loading