Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #852: Allow scoping operation to a single activation ID #1127

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Fix #852: Allow scoping operation to a single activation ID #1127

merged 11 commits into from
Nov 21, 2023

Conversation

jandusil
Copy link
Contributor

  • Add a new column activation_id into table pa_operation
  • Update OperationEntity
  • Update OperationCreateRequest
  • Update OperationServiceBehavior::createOperation
  • Update OperationServiceBehavior::attemptApproveOperation
  • Add tests
  • Update DDL, Liquibase, migration guide and REST API documentation

@jandusil
Fix #852: Allow scoping operation to a single activation ID
ccb6a42 
- Add a new column activation_id into table pa_operation
- Update OperationEntity
- Update OperationCreateRequest
- Update OperationServiceBehavior::createOperation
- Update OperationServiceBehavior::attemptApproveOperation
- Add tests
 - Update DDL, Liquibase, migration guide and REST API documentation
@jandusil jandusil requested a review from romanstrobl November 13, 2023 06:45
@jandusil jandusil self-assigned this Nov 13, 2023
@jandusil jandusil linked an issue Nov 13, 2023 that may be closed by this pull request
Allow scoping operation to a single activation ID #852
Closed
@jandusil jandusil requested a review from petrdvorak November 13, 2023 06:47
@jandusil jandusil marked this pull request as draft November 13, 2023 06:48
@jandusil jandusil marked this pull request as ready for review November 13, 2023 07:30
@jandusil jandusil requested a review from banterCZ November 13, 2023 07:30
romanstrobl
romanstrobl previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix the foreign key, other than this I have nothing to add.

docs/db/changelog/changesets/powerauth-java-server/1.6.x/20231112-add-activation-id.xml Outdated Show resolved Hide resolved
@jandusil
Fix #852: Allow scoping operation to a single activation ID
475efc2 
- Add validation
- Add API docs for swagger
- Add foreignKey
- Fix documentations
@jandusil
Copy link
Contributor Author

jandusil commented Nov 15, 2023 •
edited
Loading

Thank you for your comments. Few things that I have fixed extra while changing the documentation.

In WebServices-Methods.md the OperationCreateRequest description was wrong. Missing activationFlag and there was applicationId property instead of applications.

Moreover, I have added the Swagger annotation, added validation for activationId and made application_id a foreign key as requested.

@jandusil jandusil requested a review from banterCZ November 15, 2023 10:20
romanstrobl
romanstrobl previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found several typos now, otherwise good job!

docs/PowerAuth-Server-1.6.0.md Outdated Show resolved Hide resolved
...tlime/security/powerauth/app/server/service/behavior/tasks/OperationServiceBehaviorTest.java Outdated Show resolved Hide resolved
...tlime/security/powerauth/app/server/service/behavior/tasks/OperationServiceBehaviorTest.java Outdated Show resolved Hide resolved
banterCZ
banterCZ reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch_db_structure.png should be regenerated.

docs/db/changelog/changesets/powerauth-java-server/1.6.x/20231112-add-activation-id.xml Outdated Show resolved Hide resolved
...tlime/security/powerauth/app/server/service/behavior/tasks/OperationServiceBehaviorTest.java Outdated Show resolved Hide resolved
...tlime/security/powerauth/app/server/service/behavior/tasks/OperationServiceBehaviorTest.java Show resolved Hide resolved
@jandusil jandusil requested a review from banterCZ November 21, 2023 11:30
banterCZ
banterCZ approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jandusil jandusil merged commit 5097f37 into develop Nov 21, 2023
5 checks passed
@jandusil jandusil deleted the issues/852-operation-activationId branch November 21, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

@romanstrobl romanstrobl romanstrobl left review comments

@petrdvorak petrdvorak Awaiting requested review from petrdvorak

Assignees

@jandusil jandusil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow scoping operation to a single activation ID
3 participants
@jandusil @banterCZ @romanstrobl