Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow scoping operation to a single activation ID #852

Closed
petrdvorak opened this issue Feb 6, 2023 · 6 comments · Fixed by #1127
Closed

Allow scoping operation to a single activation ID #852

petrdvorak opened this issue Feb 6, 2023 · 6 comments · Fixed by #1127
Assignees
@jandusil @kopovan
Labels
enhancement release

Comments

@petrdvorak
Copy link
Member

To improve use cases on mobile, it would be nice to allow specifying an operation ID for a particular mobile device defined by activation ID. As a result, the developers could:

  • Create a new operation on a specific mobile device (activation ID).
  • Approve the operation just on that specific mobile device (activation ID).
@OliverJanstaWultra
Copy link
Member

Please analyze - @romanstrobl

@romanstrobl
Copy link
Member

Analyzed in https://github.com/wultra/powerauth-cloud/issues/397

jandusil added a commit that referenced this issue Nov 13, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
ccb6a42 
- Add a new column activation_id into table pa_operation
- Update OperationEntity
- Update OperationCreateRequest
- Update OperationServiceBehavior::createOperation
- Update OperationServiceBehavior::attemptApproveOperation
- Add tests
 - Update DDL, Liquibase, migration guide and REST API documentation
@jandusil jandusil linked a pull request Nov 13, 2023 that will close this issue
Fix #852: Allow scoping operation to a single activation ID #1127
Merged
jandusil added a commit that referenced this issue Nov 13, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
866b46e 
- Add test for MapToJsonConverter.json
- Fix PR reviews
jandusil added a commit that referenced this issue Nov 13, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
c878982
jandusil added a commit that referenced this issue Nov 13, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
1d24e02
jandusil added a commit that referenced this issue Nov 15, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
475efc2 
- Add validation
- Add API docs for swagger
- Add foreignKey
- Fix documentations
jandusil added a commit that referenced this issue Nov 15, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
9ccbc0a 
- Put parsing logic directly to PAS
- Switch to Map<String, Object>
jandusil added a commit that referenced this issue Nov 15, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
2add046
jandusil added a commit that referenced this issue Nov 15, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
ed125f1
jandusil added a commit that referenced this issue Nov 15, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
22371c7
jandusil added a commit that referenced this issue Nov 15, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
724d059
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
25321ca 
- Fix typos
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
aa48fab
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
9e7699f
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
b11663e
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
731fcf7
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID
9b50b4e
jandusil added a commit that referenced this issue Nov 21, 2023
@jandusil
Fix #852: Allow scoping operation to a single activation ID (#1127)
5097f37 
* Fix #852: Allow scoping operation to a single activation ID
- Add a new column activation_id into table pa_operation
- Update OperationEntity
- Update OperationCreateRequest
- Update OperationServiceBehavior::createOperation
- Update OperationServiceBehavior::attemptApproveOperation
- Add tests
 - Update DDL, Liquibase, migration guide and REST API documentation
- Add validation
- Add API docs for swagger
- Add foreignKey
- Fix documentations
@OliverJanstaWultra
Copy link
Member

@jandusil will let @kopovan know about how to test it.

@kopovan
Copy link

kopovan commented Dec 8, 2023

Testing on PACE blocked by #1174

@kopovan
Copy link

kopovan commented Dec 13, 2023

Waiting for a fix: https://github.com/wultra/powerauth-cloud/issues/397#issuecomment-1853596066

@kopovan
Copy link

kopovan commented Jan 5, 2024

test ok, see more in the comment: #1224 (comment)

@banterCZ banterCZ mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jandusil jandusil

@kopovan kopovan

Labels
enhancement release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #852: Allow scoping operation to a single activation ID wultra/powerauth-server
7 participants
@petrdvorak @banterCZ @zcgandcomp @romanstrobl @OliverJanstaWultra @jandusil @kopovan