Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epilogue] Fix epilogue generating incorrect packages for inner classes #7439

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

SamCarlberg
Copy link
Member

@SamCarlberg SamCarlberg commented Nov 28, 2024

package foo;

class Outer {
  @Logged
  static class Inner {}
}

would attempt to generate a foo/Outer/InnerLogger.java file, where the Outer package name in the generated output would conflict with the Outer class name in the user source

This fixes the issue by generating files likefoo/Outer$InnerLogger.java

Resolves wpilibsuite/2025Beta#54

@SamCarlberg SamCarlberg requested a review from a team as a code owner November 28, 2024 04:06
@SamCarlberg SamCarlberg added the component: epilogue Annotation-based logging library label Nov 28, 2024
@PeterJohnson PeterJohnson merged commit 9607c6c into wpilibsuite:main Nov 28, 2024
44 checks passed
@SamCarlberg SamCarlberg deleted the fix/logging-inner-classes branch November 28, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: epilogue Annotation-based logging library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epilogue trouble annotating inner classes
2 participants