-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmd] Add a warning to schedule
javadocs
#7073
Open
spacey-sooty
wants to merge
3
commits into
wpilibsuite:main
Choose a base branch
from
spacey-sooty:schedule-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Sep 13, 2024
The preferred design pattern should be explained, not just a warning about use. |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
September 13, 2024 04:13
7cf1e9c
to
b427b2e
Compare
/format |
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Sep 13, 2024
calcmogul
changed the title
[commands] Add a warning to
[cmd] Add a warning to Sep 16, 2024
schedule
javadocsschedule
javadocs
I think you can use @warning for the c++ |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
September 28, 2024 11:23
d003a37
to
6eb9b24
Compare
/format |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
September 28, 2024 11:39
6eb9b24
to
32a9c22
Compare
/format |
@sciencewhiz can you review? |
spacey-sooty
force-pushed
the
schedule-warning
branch
from
October 23, 2024 01:27
16c19f5
to
2a1178c
Compare
/format |
Starlight220
reviewed
Nov 4, 2024
wpilibNewCommands/src/main/native/include/frc2/command/CommandScheduler.h
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/include/frc2/command/CommandScheduler.h
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
schedule-warning
branch
from
December 3, 2024 02:18
46f9b37
to
2613107
Compare
Signed-off-by: Jade Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.