Closes #7161: Host Google Fonts - Measure time

[Miraeld]

Description

Fixes #7161
Nothing will impact the user.

Type of change

• Chore

Detailed scenario

No special scenario, just enable the feature host google font and load a page. Within WP Rocket debug file you'll find the execution time logged.

Technical description

Documentation

This pull request introduces performance measurement and logging for the rewrite_fonts method in the Frontend/Controller.php file. The most important changes include adding start and end time measurements and logging the total execution time for the method.

Performance measurement and logging:

• inc/Engine/Media/Fonts/Frontend/Controller.php: Added start time measurement at the beginning of the rewrite_fonts method for test purposes.
• inc/Engine/Media/Fonts/Frontend/Controller.php: Added end time measurement and logged the total execution time for the rewrite_fonts method.

New dependencies

None

Risks

None

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.
• Output messages (errors, notices, logs) are explicit enough for users to understand the issue and are actionnable.

Unticked items justification

No tests required for this tasks.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.01% (target: -0.10%)	✅ 100.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (b96427d)	38431	16873	43.90%
Head commit (37ad77a)	38438 (+7)	16880 (+7)	43.91% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7163)	7	7	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[MathieuLamiot]

cc @piotrbak @DahmaniAdame This PR should allow you to further investigate timing of the feature if you want.

[Miraeld]

Update status of this PR:

This pull request introduces changes to the rewrite_fonts function in the inc/Engine/Media/Fonts/Frontend/Controller.php file to add performance measurement and logging for test purposes. The most important changes include the addition of time measurement, font counting, and logging of execution time and font counts.

Performance measurement and logging:

• Added start time measurement at the beginning of the rewrite_fonts function to track execution time.
• Counted the number of fonts processed, including separate counts for v1_fonts and v2_fonts.
• Added end time measurement and logged the total execution time along with the number of fonts processed and their breakdown.

[hanna-meda]

Thank you, @Miraeld, for this PR.
We can now see measurements in logs for duration & fonts processed:

FYI, @DahmaniAdame & @piotrbak

[DahmaniAdame]

The count count( $v1_fonts ) and count( $v1_fonts ) is wrong.

You are basically counting how many items are on this array:

array (
    0 => array (
        0 => '',
        1 => '"',
        'url' => 'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Montserrat+Underline:ital,wght@0,100..900;1,100..900&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Montserrat+Underline:ital,wght@0,100..900;1,100..900&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Yuji+Mai&family=Montserrat+Underline:ital,wght@0,100..900;1,100..900&family=Open+Sans:ital,wght@0,300..800;1,300..800&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Yuji+Mai&display=swap',
        2 => 'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Montserrat+Underline:ital,wght@0,100..900;1,100..900&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Montserrat+Underline:ital,wght@0,100..900;1,100..900&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Yuji+Mai&family=Montserrat+Underline:ital,wght@0,100..900;1,100..900&family=Open+Sans:ital,wght@0,300..800;1,300..800&family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&family=Yuji+Mai&display=swap',
    ),
)

It will always return 1.

What needs to be counted is how many font URL are on the font CSS file referred to on url. It can be done by checking the recurrence of fonts.gstatic.com on it.

[DahmaniAdame]

Also, to get a meaningful result, we need to show on the logs an average loading time per font. Basically $duration / $total_fonts in addition to individual $duration and $total_fonts`.