Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host Google Fonts - Measure time #7161

Open
jeawhanlee opened this issue Dec 3, 2024 · 3 comments · Fixed by #7163
Open

Host Google Fonts - Measure time #7161

jeawhanlee opened this issue Dec 3, 2024 · 3 comments · Fixed by #7163
Assignees
Labels
effort: [XS] < 1 day of estimated development time type: enhancement Improvements that slightly enhance existing functionality and are fast to implement type: new feature Indicates the issue is a request for new functionality
Milestone

Comments

@jeawhanlee
Copy link
Contributor

Context
The Host Google Fonts feature presents a risk to slow down the loading of the page, during preload for instance. We must have a way to measure the impact of the feature on processing time.

Expected behavior
We must be able to retrieve logs (typically when WPR DEBUG is enabled) about:

  • Time it takes to run the Host Google Fonts feature when processing a new page
  • Details about the time taken for main steps of the process. We expect the risk to come from downloading the fonts and CSS so those two steps should be measured. Other steps could be measured too if it seems relevant.

You can check this to see how to add logs.

Acceptance Criteria
I can retrieve logs about how long it takes to process the Host Google Fonts feature on a page:

  • Activate the logs
  • Browse a page that has not been preloaded yet, nor has Google Fonts optimization ready yet (no files downloaded, etc).
  • Check the logs: the total execution time of Google Fonts, as well as time to download the CSS files and the time to download the fonts must be available.

When logs are deactivated, timing measurments must not happen.

@jeawhanlee
Copy link
Contributor Author

Scope a solution ✅

Estimate the effort ✅

[XS]

@jeawhanlee jeawhanlee added effort: [XS] < 1 day of estimated development time type: enhancement Improvements that slightly enhance existing functionality and are fast to implement type: new feature Indicates the issue is a request for new functionality labels Dec 3, 2024
@Miraeld
Copy link
Contributor

Miraeld commented Dec 3, 2024

Looks good to me.

@Miraeld Miraeld self-assigned this Dec 3, 2024
Miraeld added a commit that referenced this issue Dec 3, 2024
@Miraeld Miraeld linked a pull request Dec 3, 2024 that will close this issue
8 tasks
@DahmaniAdame
Copy link
Contributor

It will be good to add the number of fonts processed to have a correlation between the two. This will help support anticipate the potential impact just by checking the number of fonts without activating the log.

@hanna-meda hanna-meda self-assigned this Dec 4, 2024
@remyperona remyperona added this to the 3.18 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time type: enhancement Improvements that slightly enhance existing functionality and are fast to implement type: new feature Indicates the issue is a request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants