Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #55: Adds template to e2e tests #58

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Closes #55: Adds template to e2e tests #58

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6b2289
Closes #55: Adds template to e2e tests
Miraeld Mar 26, 2024
b5225bb
Fix feedback
Miraeld Mar 27, 2024
371b870
Fix feedback
Miraeld Mar 27, 2024
337da3d
Feedback
Miraeld Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/wp.config.sample.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ const SCENARIO_URLS = {
path: '',
mobile: true,
},
llcssDoubleColon: {
Miraeld marked this conversation as resolved.
Show resolved Hide resolved
path: 'll_bg_css_double_colon'
},
llcssSingleColon: {
Miraeld marked this conversation as resolved.
Show resolved Hide resolved
path: 'll_bg_css_simple_colon'
Miraeld marked this conversation as resolved.
Show resolved Hide resolved
}
}

/**
Expand Down
19 changes: 19 additions & 0 deletions src/features/ll-css-bg-image-double-colon.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
@llcssbg @setup
Feature: C14626 - Should lazyload CSS background images inside internal, and external CSS - Double colon
Background:
Given I am logged in
And plugin is installed 'new_release'
And plugin is activated
When I go to 'wp-admin/options-general.php?page=wprocket#dashboard'
And I save settings 'media' 'lazyloadCssBgImg'

Scenario: Open the page template and compare to nowprocket
Then I must not see any visual regression 'llcssDoubleColon'
Miraeld marked this conversation as resolved.
Show resolved Hide resolved
Then I must not see any error in debug.log
When I log out
Then no error in the console different than nowprocket page 'll_bg_css_double_colon'

Scenario: Inspect the element that loads the background image
When I log out
And I go to 'll_bg_css_double_colon'
Then I must see the correct style in the head
19 changes: 19 additions & 0 deletions src/features/ll-css-bg-image-single-colon.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
@llcssbg @setup
Feature: C14626 - Should lazyload CSS background images inside internal, and external CSS - Single colon
Background:
Given I am logged in
And plugin is installed 'new_release'
And plugin is activated
When I go to 'wp-admin/options-general.php?page=wprocket#dashboard'
And I save settings 'media' 'lazyloadCssBgImg'

Scenario: Open the page template and compare to nowprocket
Then I must not see any visual regression 'llcssSingleColon'
Miraeld marked this conversation as resolved.
Show resolved Hide resolved
Then I must not see any error in debug.log
When I log out
Then no error in the console different than nowprocket page 'll_bg_css_single_colon'

Scenario: Inspect the element that loads the background image
When I log out
And I go to 'll_bg_css_single_colon'
Then I must see the correct style in the head
Loading