Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #55: Adds template to e2e tests #58

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Mar 26, 2024

Description

Fixes #55

Documentation

User documentation

Technical documentation

Pages https://e2e.rocketlabsqa.ovh/ll_bg_css_double_colon/ & https://e2e.rocketlabsqa.ovh/ll_bg_css_single_colon/ have been created to ensure the test are running.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

@Miraeld Miraeld added the enhancement New feature or request label Mar 26, 2024
@Miraeld Miraeld requested a review from a team March 26, 2024 09:25
@Miraeld Miraeld self-assigned this Mar 26, 2024
@Miraeld Miraeld requested a review from jeawhanlee March 27, 2024 02:51
config/wp.config.sample.ts Outdated Show resolved Hide resolved
config/wp.config.sample.ts Outdated Show resolved Hide resolved
config/wp.config.sample.ts Outdated Show resolved Hide resolved
@Miraeld Miraeld requested a review from jeawhanlee March 27, 2024 11:53
@Miraeld Miraeld requested a review from jeawhanlee March 29, 2024 04:15
@Mai-Saad
Copy link
Contributor

Mai-Saad commented Apr 3, 2024

@Miraeld Thanks for the PR. Please find notes below:
1- Two of the backstop-generated reports are empty (probably the ones related to single/double colon templates) => I checked backstop.json here and can't see any entry for the 2 new pages
2- The templates of single/double colon require hover on some elements, so we can either handle hover on test or see if we can update the template itself .. @jeawhanlee what do you think?

Update
1- works fine after updating the wp-config.ts file to match the sample file
2- we can discuss if we will need to handle the hover

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Apr 5, 2024

@Mai-Saad Mai-Saad merged commit 573db34 into trunk Apr 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add templates from the QA team to visual non-reg/error check of 3.15
3 participants