Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tf-monitoring): k8s labels for api queue have changed #1332

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix(tf-monitoring): k8s labels for api queue have changed #1332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tf/modules/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# tf-module-monitoring-24
- Fix log group lookup for platform summary dashboard

# tf-module-monitoring-23
- Attempt to fix logical SQL backup alerting policy (alignment period 1h -> 15m)

Expand Down
4 changes: 2 additions & 2 deletions tf/modules/monitoring/platform-summary.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ resource "google_logging_metric" "platform-summary-metrics" {
resource.type="k8s_container"
resource.labels.cluster_name="${var.cluster_name}"
resource.labels.namespace_name="default"
labels.k8s-pod/app_kubernetes_io/component="queue"
labels.k8s-pod/app_kubernetes_io/component="queue-default"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it would make sense to start using a variable here. Maybe yes, as we'll soon move the job to a dedicated job, changing the name again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally still think this is fine to hardcode here; sure we'll move it soon but probably repeatedly after that

labels.k8s-pod/app_kubernetes_io/instance="api"
labels.k8s-pod/app_kubernetes_io/name="api" severity>=DEFAULT
jsonPayload.platform_summary_version="v1"
Expand All @@ -30,4 +30,4 @@ resource "google_logging_metric" "platform-summary-metrics" {
}

timeouts {}
}
}