fix(tf-monitoring): k8s labels for api queue have changed #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m90
commented
Dec 20, 2023
| @@ -5,7 +5,7 @@ resource "google_logging_metric" "platform-summary-metrics" { | |||
| resource.type="k8s_container" | |||
| resource.labels.cluster_name="${var.cluster_name}" | |||
| resource.labels.namespace_name="default" | |||
| labels.k8s-pod/app_kubernetes_io/component="queue" | |||
| labels.k8s-pod/app_kubernetes_io/component="queue-default" | |||
There was a problem hiding this comment.
Not sure if it would make sense to start using a variable here. Maybe yes, as we'll soon move the job to a dedicated job, changing the name again.
There was a problem hiding this comment.
I personally still think this is fine to hardcode here; sure we'll move it soon but probably repeatedly after that
m90
changed the title
m90
force-pushed
the
fr/fix-ps-dashboard
branch
from
36b5174 to
5cde1e8
Compare
tarrow
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform stats went missing since shipping #1329 as the deployment objects now have different labels, and the query in this module would yield no results.