Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Mostly downgrade required Node version from 16 to 14" #533

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Revert "Mostly downgrade required Node version from 16 to 14" #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/code-quality.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: "14"

- name: Setup NPM
run: npm install -g npm@8
# Node 14 (above) comes with NPM v6,
# which does not install peer dependencies that we need
node-version: "16"

- name: Install Dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Please report bugs on [phabricator](https://phabricator.wikimedia.org/project/vi

## Local Development

_**Prerequisites: This repository requires node v14+ and npm v7+**_
_**Prerequisites: This repository requires node v16 and up**_

### Initial setup

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
},
"homepage": "https://github.com/wmde/new-lexeme-special-page#readme",
"engines": {
"node": ">=14"
"node": ">=16"
},
"dependencies": {
"@wmde/wikibase-datamodel-types": "^0.2.0",
Expand Down