Revert "Mostly downgrade required Node version from 16 to 14" #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation at the time was apparently that Fresh [1] only supported up to Node 14, but nowadays it supports up to 20, and 18 is the default. Meanwhile, some CI errors on #519 indicate that dependencies such as @vue/language-core are starting to require syntax like `??=` that’s not available in Node 14. Let’s bump the Node requirement to 16, the version we use in WikibaseLexeme CI. This reverts commit db8ae7d (#151). [1]: https://github.com/wikimedia/fresh Bug: T348108
lucaswerkmeister
force-pushed
the
node16
branch
from
ca227c7 to
f7fbc97
Compare
micgro42
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation at the time was apparently that Fresh only supported up to Node 14, but nowadays it supports up to 20, and 18 is the default. Meanwhile, some CI errors on #519 indicate that dependencies such as @vue/language-core are starting to require syntax like
??=that’s not available in Node 14. Let’s bump the Node requirement to 16, the version we use in WikibaseLexeme CI.This reverts commit db8ae7d (#151).
Bug: T348108