Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functions for 5.0.0 release #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lucaswerkmeister
Copy link
Member

These were already deprecated in 4.0.0, so let’s completely remove them with the next major version.

These were already deprecated in 4.0.0, so let’s completely remove them
with the next major version.
@lucaswerkmeister
Copy link
Member Author

They don’t seem to have had any tests, so there’s nothing to remove there as far as I can see.

@JeroenDeDauw
Copy link
Contributor

IIRC this library was written as part of AskSerialization (abandoned/never used) and then got extracted. Leaving a bunch of stuff uncovered by direct tests.

You might want to hold off on actually releasing a new major version. It will create a bunch of work which might not be justified.

Direct dependents that will need updating: https://packagist.org/packages/serialization/serialization/dependents?order_by=downloads. Indirect ones include all dependents of Datavalues Seralization. Note some false positives in the list there, such as SMW, which no longer uses this library.

@JeroenDeDauw
Copy link
Contributor

Btw if you are writing new code that does "serialization", using a more local interface probably makes sense if you are not somehow forced into using this one.

@wiese
Copy link
Contributor

wiese commented Mar 19, 2020

Btw if you are writing new code that does "serialization", using a more local interface probably makes sense if you are not somehow forced into using this one.

Thanks for making this explicit!

@micgro42 micgro42 mentioned this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants