Drop PHP 7.0 and PHP 7.1 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These versions are no longer supported by MediaWiki, Wikibase or PHP itself. Also, they are blocking #28. This currently keeps PHP 7.2 as Wikimedia production is still on PHP 7.2 and will need a bit more time to change: https://phabricator.wikimedia.org/T257879#6339607
lucaswerkmeister
approved these changes
Oct 12, 2020
|
I agree. I can't explain it well, but from what I remember it was often argued that such changes should not qualify as breaking ones. |
itamargiv
approved these changes
Oct 13, 2020
|
There is no need to bump the major version for requirement changes to PHP or dependent upon packages since composer already takes care of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These versions are no longer supported by MediaWiki, Wikibase or PHP itself. Also, they are blocking #28.
This currently keeps PHP 7.2 as Wikimedia production is still on PHP 7.2 and will need a bit more time to change: https://phabricator.wikimedia.org/T257879#6339607
Depending on how one wants to look at it, this might be seen as a breaking change that requires a new major version release? That would seem to be related to the discussion in #27, the result of which isn't entirely clear to me.