revert: revert field size

wix · Nov 28, 2023 · 26cc542 · 26cc542
1 parent 67399e5
commit 26cc542
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 13 deletions.
diff --git a/libs/external-db-mssql/src/sql_schema_translator.spec.ts b/libs/external-db-mssql/src/sql_schema_translator.spec.ts
@@ -68,7 +68,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(65535)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(2048)`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-mssql/src/sql_schema_translator.ts b/libs/external-db-mssql/src/sql_schema_translator.ts
@@ -115,11 +115,11 @@ export default class SchemaColumnTranslator {
         try {
             const parsed = parseInt(length as string)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(65535)'
+                return '(2048)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(65535)'
+            return '(2048)'
         }
     }
 

diff --git a/libs/external-db-mysql/src/sql_schema_translator.spec.ts b/libs/external-db-mysql/src/sql_schema_translator.spec.ts
@@ -68,7 +68,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(65535)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(2048)`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-mysql/src/sql_schema_translator.ts b/libs/external-db-mysql/src/sql_schema_translator.ts
@@ -142,11 +142,11 @@ export default class SchemaColumnTranslato {
         try {
             const parsed = parseInt(length)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(65535)'
+                return '(204865535)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(65535)'
+            return '(2048)'
         }
     }
 

diff --git a/libs/external-db-postgres/src/sql_schema_translator.spec.ts b/libs/external-db-postgres/src/sql_schema_translator.spec.ts
@@ -54,7 +54,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeIdentifier(ctx.fieldName)} varchar(65535)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeIdentifier(ctx.fieldName)} varchar(2048)`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-postgres/src/sql_schema_translator.ts b/libs/external-db-postgres/src/sql_schema_translator.ts
@@ -137,11 +137,11 @@ export default class SchemaColumnTranslator {
         try {
             const parsed = parseInt(length)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(65535)'
+                return '(2048)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(65535)'
+            return '(2048)'
         }
     }
 

diff --git a/libs/external-db-spanner/src/sql_schema_translator.spec.ts b/libs/external-db-spanner/src/sql_schema_translator.spec.ts
@@ -56,7 +56,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(65535)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(2048)`)
             })
 
             test('string with length', () => {
@@ -76,7 +76,7 @@ describe('Sql Schema Column Translator', () => {
             })
 
             test('text language', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'language' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(65535)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'language' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(2048)`)
             })  
         })
 

diff --git a/libs/external-db-spanner/src/sql_schema_translator.ts b/libs/external-db-spanner/src/sql_schema_translator.ts
@@ -126,11 +126,11 @@ export default class SchemaColumnTranslator implements ISpannerSchemaColumnTrans
         try {
             const parsed = parseInt(length as string)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(65535)'
+                return '(2048)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(65535)'
+            return '(2048)'
         }
     }