rector: updated max length of test field

wix · Nov 28, 2023 · 67399e5 · 67399e5
1 parent af90b3c
commit 67399e5
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 14 deletions.
diff --git a/libs/external-db-mssql/src/sql_schema_translator.spec.ts b/libs/external-db-mssql/src/sql_schema_translator.spec.ts
@@ -68,7 +68,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(4096)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(65535)`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-mssql/src/sql_schema_translator.ts b/libs/external-db-mssql/src/sql_schema_translator.ts
@@ -115,11 +115,11 @@ export default class SchemaColumnTranslator {
         try {
             const parsed = parseInt(length as string)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(4096)'
+                return '(65535)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(4096)'
+            return '(65535)'
         }
     }
 

diff --git a/libs/external-db-mysql/src/sql_schema_translator.spec.ts b/libs/external-db-mysql/src/sql_schema_translator.spec.ts
@@ -68,7 +68,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(4096)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(65535)`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-mysql/src/sql_schema_translator.ts b/libs/external-db-mysql/src/sql_schema_translator.ts
@@ -142,11 +142,11 @@ export default class SchemaColumnTranslato {
         try {
             const parsed = parseInt(length)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(4096)'
+                return '(65535)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(4096)'
+            return '(65535)'
         }
     }
 

diff --git a/libs/external-db-spanner/src/sql_schema_translator.spec.ts b/libs/external-db-spanner/src/sql_schema_translator.spec.ts
@@ -56,7 +56,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(2048)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(65535)`)
             })
 
             test('string with length', () => {
@@ -76,7 +76,7 @@ describe('Sql Schema Column Translator', () => {
             })
 
             test('text language', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'language' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(2048)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'language' }) ).toEqual(`${escapeId(ctx.fieldName)} STRING(65535)`)
             })  
         })
 

diff --git a/libs/external-db-spanner/src/sql_schema_translator.ts b/libs/external-db-spanner/src/sql_schema_translator.ts
@@ -126,11 +126,11 @@ export default class SchemaColumnTranslator implements ISpannerSchemaColumnTrans
         try {
             const parsed = parseInt(length as string)
             if (isNaN(parsed) || parsed <= 0) {
-                return '(2048)'
+                return '(65535)'
             }
             return `(${parsed})`
         } catch (e) {
-            return '(2048)'
+            return '(65535)'
         }
     }
 

diff --git a/libs/velo-external-db-core/src/utils/schema_utils.spec.ts b/libs/velo-external-db-core/src/utils/schema_utils.spec.ts
@@ -107,8 +107,8 @@ describe('Schema utils functions', () => {
     })
 
     describe('Precision for columns', () => {
-        test.each(FieldsWithPrecision)('%s column should have a precision of 50', (columnName,) => {
-            expect(fieldKeyToPrecision(columnName)).toEqual(50)
+        test.each(FieldsWithPrecision)('%s column should have a precision of 255', (columnName,) => {
+            expect(fieldKeyToPrecision(columnName)).toEqual(255)
         })
         test('other column should not have a precision', () => { expect(fieldKeyToPrecision(ctx.column.name)).toBeUndefined() })
     })
@@ -126,7 +126,7 @@ describe('Schema utils functions', () => {
                 name: columnName,
                 type: 'text',
                 subtype: 'string',
-                precision: 50,
+                precision: 255,
             })
         })
 

diff --git a/libs/velo-external-db-core/src/utils/schema_utils.ts b/libs/velo-external-db-core/src/utils/schema_utils.ts
@@ -209,7 +209,7 @@ export const responseFieldToWixFormat = (fields: ResponseField[]): collectionSpi
 }
 
 export const fieldKeyToPrecision = (fieldKey: string): number | undefined => {
-    return FieldsWithPrecision.includes(fieldKey) ? 50 : undefined
+    return FieldsWithPrecision.includes(fieldKey) ? 255 : undefined
 }
 
 export const wixFormatFieldToInputFields = (field: collectionSpi.Field): InputField => ({