-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FR translations #52
Update FR translations #52
Conversation
damsfx
commented
Jun 18, 2024
- Add missing translations
- Apostrophe standardization
- Add missing translations - Apostrophe standardization
@mjauvin thoughts on the apostrophe suggestion in this PR? |
I also believe that some OS's (or some fonts that those OS's use) may also substitute single quotes with more "fancy" versions as needed. It's likely that won't happen if you are already using a "fancy" quote. |
@LukeTowers @mjauvin @bennothommo
Having said that, I don't have problem following the WinterCMS convention on this subject, I just wanted to standardize the translations because both forms are used in the same file. |
@damsfx I would prefer if you don't escape the single quote and use double quote around the whole strings when a single quote is used inside |
Unless the other maintainers prefer the escaped single quote? |
I prefer single quotes with escapes as it prevents you accidently parsing a var when you are intending to display a variable name. I.e. echo 'Hello, I\'m sure you meant to set $example';
// vs.
echo "Hello, I'm sure you meant to set $example"; I'm not massively concerned either way though :) |
I don't have an opinion personally, although I'd prefer to more closely follow the style conventions of the language in question so that it's a more natural experience for users of that language. Having said that, I don't actually use French so I'll defer to the people who actually use it to provide recommendations on what we use for punctuation in our localization strings. |
I prefer single quotes and escaping too. Not only does it more evidently separate the actual string from variables and the like, I still have this unproven crackpot theory that favouring these types of strings provides a really marginal performance improvement because PHP doesn't have to parse the strings for variables. EDIT: Also, happy to take @damsfx's advice on the quotes with respect to using the special quotes depending on the context. |
Allright, we're going to use single quotes and escape the single quote when present. We should do this accross the code base for consistency. Thanks @damsfx |
@mjauvin Could you add that to the Developer Guide so that we have a published reference for the future? |