Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated in.ua parser #69

Closed
wants to merge 4 commits into from
Closed

Updated in.ua parser #69

wants to merge 4 commits into from

Conversation

Vanav
Copy link

@Vanav Vanav commented Jan 12, 2018

Format of whois server SUNIC reply has changed.

@weppos weppos self-assigned this Mar 26, 2018
weppos
weppos requested changes Mar 26, 2018
View reviewed changes
Copy link
Owner

@weppos weppos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs are failing. Please regenerate them with

rake spec:generate

and run the tests before committing

rake

Thanks!

girauden added a commit to girauden/whois-parser that referenced this pull request May 6, 2019
@girauden
regenerate specs see weppos#69
8da8ec2
@girauden
Copy link

girauden commented May 6, 2019

sorry I made bad manipulation

@weppos weppos mentioned this pull request Jun 25, 2019
Closed
@jarthod jarthod mentioned this pull request Oct 12, 2020
Open
@jarthod
Copy link

jarthod commented Nov 9, 2021 •
edited
Loading

For the record I ended up starting my fork in which I merged #135 which contains the fix for SUNIC so people who need this can use my fork.

gem 'whois-parser', github: 'jarthod/whois-parser' # Unofficial but more up-to-date fork, check status at https://github.com/jarthod/whois-parser

@weppos weppos closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weppos weppos weppos requested changes

Assignees

@weppos weppos

Labels
enhancement missing-tests waiting-followup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vanav @girauden @jarthod @weppos