Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work made by @Vanav in #69, here is a new PR that takes the latest version of the SUNIC WHOIS reply (yes it changed again), simplifies a bit the time parsing code to use
parse_time
, and update the specs with accurate new values, including time zone.I also verified this code with a couple other in.ua hostnames I have and it worked fine with them.
Let me know if there's anything that could be done better.
PS: I'm starting to use whois-parser for my service to notify about domain expiration (and maybe more later). So I have a lot of data about domains and TLD for which the parser is working or not (or has outdated definitions) and am ready to provide some (a lot of?) contributions if you are open. I just thought I would ask you first, not to spend too much time on this if you're not interested in them, let me know!
Thanks for this great work !
If this gets merged we can close #69