Stop landing pages from rendering at the dynamic route #11354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -36 B (0%) Total Size: 982 kB
ℹ️ View Unchanged
|
|
Address this comment within this PR https://github.com/wellcomecollection/wellcomecollection.org/pull/11353/files#r1822641388 |
Merged
rcantin-w
commented
Oct 31, 2024
rcantin-w
commented
Oct 31, 2024
| @@ -185,14 +185,11 @@ const EventPage: NextPage<EventProps> = ({ | |||
| url: '/events', | |||
| text: 'Events', | |||
| }, | |||
| ...event.series.map(series => { | |||
| console.log(series); | |||
There was a problem hiding this comment.
Just removed this log (I could see some logs in Kibana, unsure which ones they are but thought I'd remove the ones we don't need).
rcantin-w
commented
Oct 31, 2024
| @@ -84,9 +84,7 @@ const stageApiToggleCookie = createCookie({ | |||
| value: 'true', | |||
| }); | |||
|
|
|||
| // TODO: context.addCookies should run for the first test of a suite (even on beforeAll/beforeEach) | |||
There was a problem hiding this comment.
This TODO is 3 yrs old, and we don't want all scenarios to have cookies added, so removing.
rcantin-w
commented
Oct 31, 2024
Comment on lines
+113
to
+115
| const isLandingPageRenderingAsSubPage = | ||
| pageId === siteSection && | ||
| context.resolvedUrl.indexOf(`/${siteSection}/${pageId}`) === 0; |
There was a problem hiding this comment.
A little bit verbose to my taste, will take ideas on cleverer ways of checking this.
|
|
||
| return `${docSiteSection ? '/' + docSiteSection : ''}/${uid}`; | ||
| // Prismic previews come through here. | ||
| if ('tags' in doc) { |
There was a problem hiding this comment.
does this mean that if there is a sitesection tag, it would take precedence over doc.siteSection – and if so is that ok?
There was a problem hiding this comment.
I guess so yes, and if so it should still be the correct siteSection, so I'd say it's ok!
davidpmccormick
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#11341
Currently in prod, we render all pages tagged with the correct section at
/[section]/[uid], which means that the landing page (e.g. 'visit-us'), which is tagged with the 'visit-us' section, also renders there: https://wellcomecollection.org/visit-us/visit-usWe never link to that URL, but I'm thinking we also don't want to allow it, so this covers that.
We also simplify the
linkResolverlogic and ensure all scenarios consider whether or not the linked page is a landing page.How to test
Run locally and try all landing pages, like http://localhost:3000/visit-us/visit-us (or get-involved, or about-us)
Make sure it doesn't break anything that should work though.
http://localhost:3000/pages/visit-us
http://localhost:3000/pages/accessibility
http://localhost:3000/visit-us/visit-us
etc.
I'd also say to double check the Prismic preview still works since we've amended the
linkResolver.How can we measure success?
Just less confusion and clearer rules for Page paths.
Have we considered potential risks?
N/A if we test right and tests pass.