Fix Page preview link #11353
Merged
Fix Page preview link #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lver to account for untransformed data
rcantin-w
commented
Oct 30, 2024
|
|
||
| import { isContentType } from './content-types'; | ||
|
|
||
| type Props = { | ||
| uid?: string; | ||
| type: string; | ||
| siteSection?: SiteSection; |
There was a problem hiding this comment.
This should've always been there as it's only present in transformed documents.
|
Size Change: +220 B (+0.02%) Total Size: 982 kB
ℹ️ View Unchanged
|
|
I tried previewing the following pages:
The previews all worked, but I don't think the 'visit us' url is the expected one. If we were to stop the index page rendering at that path it would break |
You're right, and I am doing that work. I'll have to add the logic inside |
|
It's just two more lines but don't want it to become too clunky; i've pushed the change so lmk! |
gestchild
reviewed
Oct 30, 2024
| // Needed for Prismic previews | ||
| const docSiteSection = doc.tags.find(t => isSiteSection(t)); | ||
|
|
||
| const isLandingPage = docSiteSection === uid; |
There was a problem hiding this comment.
Do we need to do this for the 'siteSection' in doc case too?
There was a problem hiding this comment.
We will look into this as a separate PR
There was a problem hiding this comment.
To be addressed here #11354 (comment)
gestchild
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
#11346
Moves
siteSectiontypes and type guard intomodelfolder.Amend
linkResolverto account for untransformed data (which was causing the link to be wrong).I don't fully grasp why I couldn't import
isSiteSectionfromPageLayout(build was breaking). I know it had to do with the code not being able to compile properly. I moved it intomodelas anyway it seems to be where we keep types.How to test
Run locally and preview a Prismic
Pagelocally, see if the URL makes sense and you can actually preview it.How can we measure success?
No more broken previewing of Pages!
Have we considered potential risks?
N/A