Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split bundle parsing to new package #143

Merged
merged 9 commits into from
Feb 4, 2018
Merged

Split bundle parsing to new package #143

merged 9 commits into from
Feb 4, 2018

Commits on Feb 4, 2018

  1. Split bundle parsing to new package

    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    cddc615 View commit details
    Browse the repository at this point in the history

  2. Improve error message when webpack-configs test fails 

    The "toContainSubset" assertion is terrible when the error is in values
missing from the target object. I wasted so much time in deciphering a
build failure because of that...
    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    3041c68 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect module.exports in bundle-parser package 

    I'm beginning to really despise these lines of code in
plugin/src/analyzer.js:

    try {
      bundleInfo = parseBundle(assetFile);
    } catch (err) {
      bundleInfo = null;
    }

The `catch (err)` really catches everything. Like this bug, for example.
I had to add a `console.error(err)` in the catch block to find out
`parseBundle` wasn't a function but that I had messed up the
`module.exports`.
    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    45b753d View commit details
    Browse the repository at this point in the history

  4. Move CLI-only function to CLI file

    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    dd02da5 View commit details
    Browse the repository at this point in the history

  5. Cache bundle-parser node_modules in Travis

    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    7cb1a28 View commit details
    Browse the repository at this point in the history

  6. Transpile bundle-parser package

    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    ecf3d32 View commit details
    Browse the repository at this point in the history

  7. Move src/analyzer.js and tree.js to bundle-parser package 

    Now all parsing related functions are in the same package
    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    28ab235 View commit details
    Browse the repository at this point in the history

  8. Add README.md for bundle-parser package

    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    b5c3727 View commit details
    Browse the repository at this point in the history

  9. Use advertised API of bundle-parser package

    @valscion
    valscion committed Feb 4, 2018
    Configuration menu
    Copy the full SHA
    3382f91 View commit details
    Browse the repository at this point in the history