Split bundle parsing to new package #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valscion
force-pushed
the
split-bundle-parser
branch
from
c8f025d
to
3e60ed1
Compare
|
What's up with TravisCI not running tests for this branch?! 😩 EDIT: Oh, Travis only wanted to run tests when PR was to be ran against |
valscion
force-pushed
the
split-bundle-parser
branch
from
f00cce6
to
fdc0463
Compare
valscion
force-pushed
the
split-bundle-parser
branch
from
fdc0463
to
cddc615
Compare
The "toContainSubset" assertion is terrible when the error is in values missing from the target object. I wasted so much time in deciphering a build failure because of that...
valscion
force-pushed
the
split-bundle-parser
branch
from
bda1bc4
to
3041c68
Compare
I'm beginning to really despise these lines of code in
plugin/src/analyzer.js:
try {
bundleInfo = parseBundle(assetFile);
} catch (err) {
bundleInfo = null;
}
The `catch (err)` really catches everything. Like this bug, for example.
I had to add a `console.error(err)` in the catch block to find out
`parseBundle` wasn't a function but that I had messed up the
`module.exports`.
Now all parsing related functions are in the same package
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Version 3 upgrade #97, this PR aims to split the bundle parsing logic out of the plugin code to own package.
This new package could be useful outside of webpack-bundle-analyzer itself. Other tools who would like to access the parsed output would be able to do it and do whatever they want with the data.
TODO:
src/analyzer.jsand related code to the new package