refactor: tests (#302)

src/index.js

@@ -75,8 +75,7 @@ export default function loader(content) {
     publicPath = JSON.stringify(publicPath);
   }
 
-  // eslint-disable-next-line no-undefined
-  if (options.emitFile === undefined || options.emitFile) {
+  if (typeof options.emitFile === 'undefined' || options.emitFile) {
     this.emitFile(outputPath, content);
   }
 

test/__snapshots__/context-option.test.js.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`when applied with \`context\` option matches snapshot for \`{String}\` value 1`] = `"module.exports = __webpack_public_path__ + \\"9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";"`;

test/__snapshots__/emitFile-option.test.js.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`when applied with \`emitFile\` option matches snapshot for \`true\` (\`{Boolean}\`) (default) 1`] = `"64eababb117f90535085779cc0325003.svg"`;

test/__snapshots__/errors.test.js.snap

@@ -0,0 +1,8 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`errors validation errors 1`] = `
+"File Loader Invalid Options
+
+options.useRelativePath should be boolean
+"
+`;

test/__snapshots__/loader.test.js.snap

@@ -1,3 +1,3 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Loader Defaults 1`] = `"module.exports = __webpack_public_path__ + \\"9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";"`;
+exports[`loader should works without options 1`] = `"module.exports = __webpack_public_path__ + \\"9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";"`;

test/__snapshots__/name-option.test.js.snap

@@ -0,0 +1,5 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`when applied with \`name\` option matches snapshot for \`{Function}\` value 1`] = `"module.exports = __webpack_public_path__ + \\"9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";"`;
+
+exports[`when applied with \`name\` option matches snapshot for \`{String}\` value 1`] = `"module.exports = __webpack_public_path__ + \\"9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";"`;

test/options/__snapshots__/outputPath.test.js.snap → test/__snapshots__/outputPath-option.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Options outputPath {Function} 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{Function}\` value 1`] = `
 Object {
   "assets": Array [
     "output_path_func/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -9,7 +9,7 @@ Object {
 }
 `;
 
-exports[`Options outputPath {Function} with \`options.name\` 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{Function}\` value with \`options.name\` 1`] = `
 Object {
   "assets": Array [
     "output_path_func/file.png",
@@ -18,7 +18,7 @@ Object {
 }
 `;
 
-exports[`Options outputPath {Function} with \`publicPath\` {Function} 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{Function}\` value with \`publicPath\` (\`{Function}\`) 1`] = `
 Object {
   "assets": Array [
     "output_path_func/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -27,7 +27,7 @@ Object {
 }
 `;
 
-exports[`Options outputPath {Function} with \`publicPath\` {String} 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{Function}\` value with \`publicPath\` (\`{String}\`) 1`] = `
 Object {
   "assets": Array [
     "output_path_func/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -36,7 +36,7 @@ Object {
 }
 `;
 
-exports[`Options outputPath {String} 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{String}\` value 1`] = `
 Object {
   "assets": Array [
     "output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -45,25 +45,25 @@ Object {
 }
 `;
 
-exports[`Options outputPath {String} with \`options.name\` 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{String}\` value with \`publicPath\` (\`{Function}\`) 1`] = `
 Object {
   "assets": Array [
-    "output_path/file.png",
+    "output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
   ],
-  "source": "module.exports = __webpack_public_path__ + \\"output_path/file.png\\";",
+  "source": "module.exports = \\"public_path_func/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
 }
 `;
 
-exports[`Options outputPath {String} with \`publicPath\` {Function} 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{String}\` value with \`publicPath\` (\`{String}\`) 1`] = `
 Object {
   "assets": Array [
     "output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
   ],
-  "source": "module.exports = \\"public_path_func/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
+  "source": "module.exports = \\"public_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
 }
 `;
 
-exports[`Options outputPath {String} with \`publicPath\` {String} 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{String}\` value with \`publicPath\` (\`{String}\`) without trailing slash 1`] = `
 Object {
   "assets": Array [
     "output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -72,20 +72,20 @@ Object {
 }
 `;
 
-exports[`Options outputPath {String} with \`publicPath\` {String} without trailing slash 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{String}\` value without trailing slash 1`] = `
 Object {
   "assets": Array [
     "output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
   ],
-  "source": "module.exports = \\"public_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
+  "source": "module.exports = __webpack_public_path__ + \\"output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
 }
 `;
 
-exports[`Options outputPath {String} without trailing slash 1`] = `
+exports[`when applied with \`outputPath\` option matches snapshot for \`{String}\` with \`name\` option 1`] = `
 Object {
   "assets": Array [
-    "output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
+    "output_path/file.png",
   ],
-  "source": "module.exports = __webpack_public_path__ + \\"output_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
+  "source": "module.exports = __webpack_public_path__ + \\"output_path/file.png\\";",
 }
 `;

test/options/__snapshots__/publicPath.test.js.snap → test/__snapshots__/publicPath-option.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Options publicPath {Function} 1`] = `
+exports[`when applied with \`publicPath\` option matches snapshot for \`{Function}\` value 1`] = `
 Object {
   "assets": Array [
     "9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -9,25 +9,25 @@ Object {
 }
 `;
 
-exports[`Options publicPath {String} - URL 1`] = `
+exports[`when applied with \`publicPath\` option matches snapshot for \`{String}\` value 1`] = `
 Object {
   "assets": Array [
     "9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
   ],
-  "source": "module.exports = \\"https://cdn.com/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
+  "source": "module.exports = \\"public_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
 }
 `;
 
-exports[`Options publicPath {String} - Without trailing slash 1`] = `
+exports[`when applied with \`publicPath\` option matches snapshot for \`{String}\` value as URL 1`] = `
 Object {
   "assets": Array [
     "9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
   ],
-  "source": "module.exports = \\"public_path/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
+  "source": "module.exports = \\"https://cdn.com/9c87cbf3ba33126ffd25ae7f2f6bbafb.png\\";",
 }
 `;
 
-exports[`Options publicPath {String} 1`] = `
+exports[`when applied with \`publicPath\` option matches snapshot for \`{String}\` value without trailing slash 1`] = `
 Object {
   "assets": Array [
     "9c87cbf3ba33126ffd25ae7f2f6bbafb.png",

test/options/__snapshots__/useRelativePath.test.js.snap → test/__snapshots__/useRelativePath-option.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Options useRelativePath {Boolean} - \`false\` 1`] = `
+exports[`when applied with \`useRelativePath\` option matches snapshot for \`false\` value (\`{Boolean}\`) 1`] = `
 Object {
   "assets": Array [
     "9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -9,7 +9,7 @@ Object {
 }
 `;
 
-exports[`Options useRelativePath {Boolean} - \`true\` 1`] = `
+exports[`when applied with \`useRelativePath\` option matches snapshot for \`true\` value (\`{Boolean}\`) 1`] = `
 Object {
   "assets": Array [
     "assets/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -18,7 +18,7 @@ Object {
 }
 `;
 
-exports[`Options useRelativePath {Boolean} - \`true\` with absolute \`context\` 1`] = `
+exports[`when applied with \`useRelativePath\` option matches snapshot for \`true\` value (\`{Boolean}\`) and with absolute \`context\` 1`] = `
 Object {
   "assets": Array [
     "file-loader/test/fixtures/nested/assets/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",
@@ -27,7 +27,7 @@ Object {
 }
 `;
 
-exports[`Options useRelativePath {Boolean} - \`true\` with relative \`context\` 1`] = `
+exports[`when applied with \`useRelativePath\` option matches snapshot for \`true\` value (\`{Boolean}\`) and with relative \`context\` 1`] = `
 Object {
   "assets": Array [
     "assets/9c87cbf3ba33126ffd25ae7f2f6bbafb.png",

test/context-option.test.js

@@ -0,0 +1,20 @@
+import webpack from './helpers/compiler';
+
+describe('when applied with `context` option', () => {
+  it('matches snapshot for `{String}` value', async () => {
+    const config = {
+      loader: {
+        test: /(png|jpg|svg)/,
+        options: {
+          context: `${__dirname}`,
+        },
+      },
+    };
+
+    const stats = await webpack('fixture.js', config);
+    const [module] = stats.toJson().modules;
+    const { source } = module;
+
+    expect(source).toMatchSnapshot();
+  });
+});

test/emitFile-option.test.js

@@ -0,0 +1,38 @@
+import webpack from './helpers/compiler';
+
+describe('when applied with `emitFile` option', () => {
+  it('matches snapshot for `true` (`{Boolean}`) (default)', async () => {
+    const config = {
+      loader: {
+        test: /(png|jpg|svg)/,
+        options: {
+          emitFile: true,
+        },
+      },
+    };
+
+    const stats = await webpack('emitFile/fixture.js', config);
+    const [, module] = stats.toJson().modules;
+    const { assets } = module;
+
+    expect(assets[0]).toMatchSnapshot();
+  });
+
+  it('matches snapshot for `false` value  (`{Boolean}`)', async () => {
+    const config = {
+      loader: {
+        test: /(png|jpg|svg)/,
+        options: {
+          emitFile: false,
+        },
+      },
+    };
+
+    const stats = await webpack('emitFile/fixture.js', config);
+    const [module] = stats.toJson().modules;
+    const { assets } = module;
+
+    // eslint-disable-next-line no-undefined
+    expect(assets[0]).toBe(undefined);
+  });
+});

test/errors.test.js

@@ -0,0 +1,14 @@
+import loader from '../src';
+
+describe('errors', () => {
+  it('validation errors', () => {
+    const err = () =>
+      loader.call({
+        query: { useRelativePath: 1 },
+        emitFile: true,
+      });
+
+    expect(err).toThrow();
+    expect(err).toThrowErrorMatchingSnapshot();
+  });
+});

test/loader.test.js

@@ -1,7 +1,7 @@
 import webpack from './helpers/compiler';
 
-describe('Loader', () => {
-  test('Defaults', async () => {
+describe('loader', () => {
+  it('should works without options', async () => {
     const config = {
       loader: {
         test: /(png|jpg|svg)/,

test/name-option.test.js

@@ -0,0 +1,39 @@
+import webpack from './helpers/compiler';
+
+describe('when applied with `name` option', () => {
+  it('matches snapshot for `{String}` value', async () => {
+    const config = {
+      loader: {
+        test: /(png|jpg|svg)/,
+        options: {
+          name: '[hash].[ext]',
+        },
+      },
+    };
+
+    const stats = await webpack('fixture.js', config);
+    const [module] = stats.toJson().modules;
+    const { source } = module;
+
+    expect(source).toMatchSnapshot();
+  });
+
+  it('matches snapshot for `{Function}` value', async () => {
+    const config = {
+      loader: {
+        test: /(png|jpg|svg)/,
+        options: {
+          name() {
+            return '[hash].[ext]';
+          },
+        },
+      },
+    };
+
+    const stats = await webpack('fixture.js', config);
+    const [module] = stats.toJson().modules;
+    const { source } = module;
+
+    expect(source).toMatchSnapshot();
+  });
+});