refactor: update defaults (#301)

webpack-contrib · Dec 19, 2018 · 3981acc · 3981acc
1 parent 85230c9
commit 3981acc
Show file tree

Hide file tree

Showing 16 changed files with 4,238 additions and 4,967 deletions.
diff --git a/.babelrc b/.babelrc
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -4,25 +4,32 @@ unit_tests: &unit_tests
     - restore_cache:
         key: dependency-cache-{{ checksum "package-lock.json" }}
     - run:
-        name: NPM Rebuild
-        command: npm install
+        name: Install Latest NPM.
+        # npm@3 is buggy
+        command: if [[ $(npm -v | cut -c -1) > 3 ]] ; then npm i -g npm@latest; else echo "Skip npm updating"; fi
     - run:
-        name: Run unit tests.
+        name: NPM Install.
+        command: npm ci || npm i
+    - run:
+        name: Run Test.
         command: npm run ci:test
 canary_tests: &canary_tests
   steps:
     - checkout
     - restore_cache:
         key: dependency-cache-{{ checksum "package-lock.json" }}
     - run:
-        name: NPM Rebuild
-        command: npm install
+        name: Install Latest NPM.
+        command: npm i -g npm@latest
+    - run:
+        name: NPM Install.
+        command: npm ci
     - run:
-        name: Install Webpack Canary
+        name: Install Webpack Canary.
         command: npm i --no-save webpack@next
     - run:
-        name: Run unit tests.
-        command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "Next is older than Latest - Skipping Canary Suite"; else npm run ci:test ; fi
+        name: Run Test.
+        command: if [[ $(compver --name webpack --gte next --lt latest) < 1 ]] ; then printf "Next is older than Latest - Skipping Canary Suite"; else npm run ci:test; fi
 
 version: 2
 jobs:
@@ -34,91 +41,82 @@ jobs:
       - restore_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
-          name: Install Dependencies
-          command: npm install
+          name: Install Latest NPM.
+          command: npm i -g npm@latest
+      - run:
+          name: NPM Install.
+          command: npm ci
       - save_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
           paths:
             - ./node_modules
-
-  node8-latest:
+  analysis:
     docker:
-      - image: webpackcontrib/circleci-node8:latest
+      - image: webpackcontrib/circleci-node-base:latest
     steps:
       - checkout
       - restore_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
-          name: NPM Rebuild
-          command: npm install
+          name: Install Latest NPM.
+          command: npm i -g npm@latest
       - run:
-          name: Run unit tests.
-          command: npm run ci:coverage
+          name: NPM Install.
+          command: npm ci
       - run:
-          name: Submit coverage data to codecov.
-          command: bash <(curl -s https://codecov.io/bash)
-          when: on_success
+          name: Run linting.
+          command: npm run lint
+      - run:
+          name: Run NPM Audit.
+          command: npm run security
+      - run:
+          name: Validate Commit Messages.
+          command: npm run ci:lint:commits
   node6-latest:
     docker:
       - image: webpackcontrib/circleci-node6:latest
     <<: *unit_tests
-  node9-latest:
-    docker:
-      - image: webpackcontrib/circleci-node9:latest
-    <<: *unit_tests
-  node8-canary:
+  node8-latest:
     docker:
       - image: webpackcontrib/circleci-node8:latest
-    <<: *canary_tests
-  analysis:
+    <<: *unit_tests
+  node10-latest:
     docker:
-      - image: webpackcontrib/circleci-node-base:latest
+      - image: webpackcontrib/circleci-node10:latest
     steps:
       - checkout
       - restore_cache:
           key: dependency-cache-{{ checksum "package-lock.json" }}
       - run:
-          name: NPM Rebuild
-          command: npm install
+          name: Install Latest NPM.
+          command: npm i -g npm@latest
       - run:
-          name: Run linting.
-          command: npm run lint
+          name: NPM Install.
+          command: npm ci
       - run:
-          name: Run NSP Security Check.
-          command: npm run security
+          name: Run Test.
+          command: npm run ci:coverage
       - run:
-          name: Validate Commit Messages
-          command: npm run ci:lint:commits
-  publish:
+          name: Submit coverage data to codecov.
+          command: bash <(curl -s https://codecov.io/bash)
+          when: on_success
+  node6-canary:
     docker:
-      - image: webpackcontrib/circleci-node-base:latest
-    steps:
-      - checkout
-      - restore_cache:
-          key: dependency-cache-{{ checksum "package-lock.json" }}
-      - run:
-          name: NPM Rebuild
-          command: npm install
-      # - run:
-      #     name: Validate Commit Messages
-      #     command: npm run release:validate
-      - run:
-          name: Publish to NPM
-          command: printf "noop running conventional-github-releaser"
+      - image: webpackcontrib/circleci-node10:latest
+    <<: *canary_tests
 
-version: 2.0
 workflows:
   version: 2
-  validate-publish:
+  test:
     jobs:
       - dependency_cache
-      - node6-latest:
+      - analysis:
           requires:
             - dependency_cache
           filters:
             tags:
               only: /.*/
-      - analysis:
+      - node6-latest:
           requires:
             - dependency_cache
           filters:
@@ -131,26 +129,17 @@ workflows:
           filters:
             tags:
               only: /.*/
-      - node9-latest:
+      - node10-latest:
           requires:
             - analysis
             - node6-latest
           filters:
             tags:
               only: /.*/
-      - node8-canary:
+      - node6-canary:
           requires:
             - analysis
             - node6-latest
           filters:
             tags:
               only: /.*/
-      - publish:
-          requires:
-            - node8-latest
-            - node8-canary
-            - node9-latest
-          filters:
-            branches:
-              only:
-                - master
diff --git a/.editorconfig b/.editorconfig
@@ -9,5 +9,5 @@ insert_final_newline = true
 trim_trailing_whitespace = true
 
 [*.md]
-insert_final_newline = false
+insert_final_newline = true
 trim_trailing_whitespace = false
diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
@@ -1,65 +1,16 @@
 <!--
-  Issues are so 🔥
-
-  If you remove or skip this template, you'll make the 🐼 sad and the mighty god
-  of Github will appear and pile-drive the close button from a great height
-  while making animal noises.
-
   👉🏽 Need support, advice, or help? Don't open an issue!
   Head to StackOverflow or https://gitter.im/webpack/webpack.
--->
-
-* Operating System:
-* Node Version:
-* NPM Version:
-* webpack Version:
-* file-loader Version:
-
-<!-- Please place an x (no spaces!) in all [ ] that apply -->
-
-This issue is for a:
-
-- [ ] **bug**
-- [ ] **feature** request
-- [ ] **modification** request
-
-### Code
-
-##### CLI Command
-
-```bash
-  # paste the CLI command you're using. if this isn't applicable, it's safe to remove.
-  $ {the command}
-```
 
-##### webpack.config.js
+  Hey there!
 
-```js
-  // If your bitchin' code blocks are over 20 lines, please paste a link to a gist
-  // (https://gist.github.com).
-```
+  You arrived at this template because you felt none of the other options
+  matched the kind of issue you'd like to report. Please use this opportunity to
+  tell us about your particular type of issue so we can try to accomodate
+  similar issues in the future.
 
-```js
-  // additional code, HEY YO remove this block if you don't need it
-```
-
-### Expected Behavior
-
-<!-- Remove this section if not reporting a bug or modification request. -->
-
-### Actual Behavior
-
-<!-- Remove this section if not reporting a bug or modification request. -->
-
-### How Do We Reproduce?
-
-<!--
-  Remove this section if not reporting a bug.
-
-  If your webpack config is over 50 lines long, please provide a URL to a repo
-  for your beefy 🍖 app that we can use to reproduce.
+  PLEASE do note, if you're using this to report an issue already covered by the
+  existing template types, your issue may be closed as invalid. Our issue
+  templates contain fields that help us help you, and without that important
+  info, we might as well be ice-skating uphill, carrying a wooly mammoth.
 -->
-
-### New Feature Use Case
-
-<!-- Remove this section if not requesting a feature -->
diff --git a/.github/ISSUE_TEMPLATE/BUG.md b/.github/ISSUE_TEMPLATE/BUG.md
@@ -0,0 +1,51 @@
+---
+name: 🐛 Bug Report
+about: Something went awry and you'd like to tell us about it.
+
+---
+
+<!--
+  Issues are so 🔥
+
+  If you remove or skip this template, you'll make the 🐼 sad and the mighty god
+  of Github will appear and pile-drive the close button from a great height
+  while making animal noises.
+
+  👉🏽 Need support, advice, or help? Don't open an issue!
+  Head to StackOverflow or https://gitter.im/webpack/webpack.
+-->
+
+* Operating System:
+* Node Version:
+* NPM Version:
+* webpack Version:
+* file-loader Version:
+
+### Expected Behavior
+
+<!-- Remove this section if not reporting a bug or modification request. -->
+
+### Actual Behavior
+
+<!-- Remove this section if not reporting a bug or modification request. -->
+
+### Code
+
+```js
+  // webpack.config.js
+  // If your bitchin' code blocks are over 20 lines, please paste a link to a gist
+  // (https://gist.github.com).
+```
+
+```js
+  // additional code, HEY YO remove this block if you don't need it
+```
+
+### How Do We Reproduce?
+
+<!--
+  Remove this section if not reporting a bug.
+
+  If your webpack config is over 50 lines long, please provide a URL to a repo
+  for your beefy 🍖 app that we can use to reproduce.
+-->