refactor: replace authorization custom code with standard ff pipes #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mericakgul
commented
Jun 14, 2024
mericakgul
commented
- Three diffferent adapters for each api (documenten-api, catalogi-api, zaken-api) has been created in order to create authorization token.
- Each adapter manages one of three auth types which are jwt, basic and value. According to the auth-type, the adapters create the valid token and also creates the Authorization header and returns it in 'Authorization' session key so it can be directly used in other pipes that requires authorization.
- jwtPipe's have been removed from the adapters it is in and instead, a new pipe which is calling the newly created authorization generator adapter has been added.
added 8 commits
June 13, 2024 15:46
…on generator adapter for catalogiApi
…on generator adapter for zakenApi
…on generator adapter for documentenApi
MLenterman
reviewed
Jun 24, 2024
src/main/configurations/Translate/Configuration_GenerateAuthorizationHeaderForCatalogiApi.xml
Outdated
Show resolved
Hide resolved
MLenterman
changed the title
MLenterman
approved these changes
Jun 25, 2024
MLenterman
deleted the
GT-1159-Replace-Authentication-CustomCode-With-FF-Pipes
branch
WeAreFrank-BOT
pushed a commit
that referenced
this pull request
Jun 25, 2024
## [1.19.10](v1.19.9...v1.19.10) (2024-06-25) ### 🧑💻 Code Refactoring * replace authorization custom code with standard ff pipes ([#393](#393)) ([1d6671b](1d6671b))
|
🎉 This PR is included in version 1.19.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.