Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace remaining custom code for authentication with standard f!f pipes #352

Closed
MLenterman opened this issue May 7, 2024 · 0 comments · Fixed by #393
Closed

Replace remaining custom code for authentication with standard f!f pipes #352

MLenterman opened this issue May 7, 2024 · 0 comments · Fixed by #393
Labels
refactor refactor

Comments

@MLenterman
Copy link
Collaborator

Originally the custom code for authentication to zgw api's supported the 3 methods: jwt, basic, value. The jwt functionality has already be replaced with the JwtPipe. Basic authentication and value should also be possible to implement with standard f!f pipes. Basic is simply <username>:<password> base64 encoded I believe and in the "Authorization" header be formatted as Basic <base64 encoded token>. The value method simply allows the user to configure a static token/password that is one on one the value of the "Authorization" header.

Would recommend to move all 3 of the authorization methods to a dedicated adapter so that it can be easily reused and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant