-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/create more space #324
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8e2e545
chore: fix deprecated options in angular.json file
MatthijsSmets 1ab9848
feat: create more space by removing replacing redundant buttons and r…
MatthijsSmets a99d336
chore: fix cypress tests with new ui changes
MatthijsSmets 5a17b69
chore: fix select all to be unchecked when unchecking a row
MatthijsSmets 51d4fe2
Merge remote-tracking branch 'origin/master' into feat/create-more-space
MatthijsSmets 27014d8
feat: allow user to select amount of spacing
MatthijsSmets a9d9e91
chore: add wait to test
MatthijsSmets f7fac33
chore: add multiply sign for spacing options
MatthijsSmets 122d48a
chore: change default value for spacing to 1
MatthijsSmets File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,51 @@ | ||
describe('Tests about copying', function() { | ||
describe("Tests about copying", function () { | ||
beforeEach(() => { | ||
cy.clearDebugStore(); | ||
}) | ||
}); | ||
|
||
afterEach(() => { | ||
cy.get('li#testTab').click(); | ||
cy.get('#SelectAllButton').click(); | ||
cy.get('.row #DeleteSelectedButton').click(); | ||
cy.get('#confirmDeletion').click(); | ||
cy.get('#debugTab').click(); | ||
cy.get("li#testTab").click(); | ||
cy.get("#SelectAllButton").click(); | ||
cy.get(".row #DeleteSelectedButton").click(); | ||
cy.get("#confirmDeletion").click(); | ||
cy.get("#debugTab").click(); | ||
}); | ||
|
||
it('Copy report to test tab', () => { | ||
cy.visit(''); | ||
cy.get('#testTab').click(); | ||
cy.get('#metadataTable tbody', {timeout: 10000}).find('tr').should('not.exist'); | ||
it("Copy report to test tab", () => { | ||
cy.visit(""); | ||
cy.get("#testTab").click(); | ||
cy.get("#metadataTable tbody", { timeout: 10000 }) | ||
.find("tr") | ||
.should("not.exist"); | ||
cy.createReport(); | ||
cy.get('#debugTab').click(); | ||
cy.get('#metadataTable tbody', {timeout: 10000}).find('tr').should('not.exist'); | ||
cy.get('.row #RefreshButton').click(); | ||
cy.get('#metadataTable tbody').find('tr').should('have.length', 1); | ||
cy.get('button[id="SelectAllReportsButton"]').click(); | ||
cy.get("#debugTab").click(); | ||
cy.get("#metadataTable tbody", { timeout: 10000 }) | ||
.find("tr") | ||
.should("not.exist"); | ||
cy.get(".row #RefreshButton").click(); | ||
cy.get("#metadataTable tbody").find("tr").should("have.length", 1); | ||
cy.get("[data-cy-select-all-reports]").click(); | ||
cy.get('button[id="OpenSelectedReportsButton"]').click(); | ||
cy.get('#debug-tree .jqx-tree-dropdown-root > li').should('have.length', 1); | ||
cy.get('button#CopyButton').click(); | ||
cy.get('li#testTab').click(); | ||
cy.get("#debug-tree .jqx-tree-dropdown-root > li").should("have.length", 1); | ||
cy.get("button#CopyButton").click(); | ||
cy.get("li#testTab").click(); | ||
// We test that the user does not have to refresh here. | ||
cy.get('tbody#testReports').find('tr').should('have.length', 1); | ||
cy.get('tbody#testReports').find('tr').contains('/Simple report').should('have.length', 1); | ||
cy.get('#debugTab').click(); | ||
cy.get('#metadataTable tbody', {timeout: 10000}).find('tr').should('have.length', 1); | ||
cy.get('#debug-tree .jqx-tree-dropdown-root > li').should('have.length', 1); | ||
cy.get('li#testTab').click(); | ||
cy.get("tbody#testReports").find("tr").should("have.length", 1); | ||
cy.get("tbody#testReports") | ||
.find("tr") | ||
.contains("/Simple report") | ||
.should("have.length", 1); | ||
cy.get("#debugTab").click(); | ||
cy.get("#metadataTable tbody", { timeout: 10000 }) | ||
.find("tr") | ||
.should("have.length", 1); | ||
cy.get("#debug-tree .jqx-tree-dropdown-root > li").should("have.length", 1); | ||
cy.get("li#testTab").click(); | ||
// Do not refresh. The test tab should have saved its state. | ||
cy.get('tbody#testReports').find('tr').should('have.length', 1); | ||
cy.get('tbody#testReports').find('tr').contains('/Simple report').should('have.length', 1); | ||
cy.get("tbody#testReports").find("tr").should("have.length", 1); | ||
cy.get("tbody#testReports") | ||
.find("tr") | ||
.contains("/Simple report") | ||
.should("have.length", 1); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im very curious what
buildTarget
is and why you changed to that instead ofbrowserTarget
. Ive never seen this beforeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running ng serve this is the warning i get:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh
Either the cli in the package.json is not matching with what you're running or something weird is going on
Edit: nvm forgot to update packages, ill check again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see some peer dependency issues