Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create more space #324

Merged
merged 9 commits into from
Jan 16, 2024
Merged

Feat/create more space #324

merged 9 commits into from
Jan 16, 2024

Conversation

MatthijsSmets
Copy link
Contributor

@MatthijsSmets MatthijsSmets commented Jan 15, 2024

Select all and deselect all buttons have been replaced with a checkbox in the table header.

Padding on table rows have been minimized to create more space.
Metadata table visible under the editor has been moved above it and can be shown or hidden with a button.
Table header names and column values have been shortened, hovering on the table header will still show the full name.

Table row spacing can be altered in settings, font size is also changed with the spacing.

@MatthijsSmets MatthijsSmets marked this pull request as ready for review January 16, 2024 10:25
@MatthijsSmets MatthijsSmets requested a review from Matthbo January 16, 2024 10:25
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im very curious what buildTarget is and why you changed to that instead of browserTarget. Ive never seen this before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running ng serve this is the warning i get:
image

Copy link
Member

@Matthbo Matthbo Jan 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh
image

Either the cli in the package.json is not matching with what you're running or something weird is going on
Edit: nvm forgot to update packages, ill check again

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see some peer dependency issues
image

@Matthbo
Copy link
Member

Matthbo commented Jan 16, 2024

Currently spacing 0 is the default but I would change that to 1 as the default.
If 1 is the default then people that want it small can make it smaller but it generally has better accessibility for people with to click on the right item.

Also only showing numbers doesnt really explain what the unit of the spacing is, that might be nice to add

@MatthijsSmets MatthijsSmets merged commit f466c9c into master Jan 16, 2024
2 checks passed
@MatthijsSmets MatthijsSmets deleted the feat/create-more-space branch May 2, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants