Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node link strategy from view to report #630

Open
jacodg opened this issue Aug 23, 2024 · 1 comment
Open

Move node link strategy from view to report #630

jacodg opened this issue Aug 23, 2024 · 1 comment
Labels
Backend Something to be changed in backend Frontend Something to be changed in frontend

Comments

@jacodg
Copy link
Contributor

jacodg commented Aug 23, 2024

It would be better to:

  • Store the link strategy with the report instead of the view so link strategy can also be used when doing a rerun to find counterpart checkpoints to check whether they need to be stubbed or not
  • Remove code in frontend to find counterpart node and call a backend api that will return the counterpart checkpoint for a report that is compared with another report for which the user selects a specific checkpoint. It will simplify the frontend and all code related to finding counterpart checkpoints based on a link strategy will be on one place

See also:

#314 (will be fixed when the above is done)
#593 (will be fixed when the above is done)
wearefrank/ladybug@4745616 (node link strategy was added to view)

@jacodg
Copy link
Contributor Author

jacodg commented Nov 11, 2024

Backend code has been changed to store link method in report. Dropdown has been added to old GUI. Link method will be used when running a report and in the compare tab.

wearefrank/ladybug@e1a63b6

REST api still has to be changed to allow the new GUI to make use of the backend code to find counterpart checkpoints:

wearefrank/ladybug@e1a63b6#diff-3d280ea4d464a0a5a7d164b85aacd0d0c6a03a99293b6ae3fc0b00a01935c148R766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Something to be changed in backend Frontend Something to be changed in frontend
Projects
Status: To do
Development

No branches or pull requests

2 participants