Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong counter checkpoint selected in compare #314

Open
jacodg opened this issue May 26, 2023 · 3 comments
Open

Wrong counter checkpoint selected in compare #314

jacodg opened this issue May 26, 2023 · 3 comments
Labels
Frontend Something to be changed in frontend

Comments

@jacodg
Copy link
Contributor

jacodg commented May 26, 2023

With Path selected as compare method and a report that has checkpoints with the same name on different levels the selected counterpart checkpoint is not correct. An extra check on checkpoint type is needed, this is now also done in the old GUI:

wearefrank/ladybug@9a785d1#diff-0ad1cb267a0b900c4b0997dfb3a70dc8940538f4be2d6ed9f4b86a6668a69e13R124

Checkpoint on the right side isn't selected anymore:

image

@celmoussaoui celmoussaoui self-assigned this Jul 17, 2023
@MatthijsSmets MatthijsSmets moved this to To do in Ladybug Jun 10, 2024
@mhdirkse
Copy link
Member

mhdirkse commented Jul 9, 2024

Dit komt in de user stories, zie frankframework/frank-manual#111, story nummers 3110 and 3120.

@MatthijsSmets
Copy link
Contributor

I only see an example with the old ladybug, recently some changes were made to the compare component, does this problem still occur? @jacodg

@MatthijsSmets MatthijsSmets moved this from To do to Needs response in Ladybug Jul 24, 2024
@jacodg
Copy link
Contributor Author

jacodg commented Aug 23, 2024

See #630

@jacodg jacodg added the Frontend Something to be changed in frontend label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Something to be changed in frontend
Projects
Status: To do
Development

No branches or pull requests

4 participants