Add pixel light support #383
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be easier to track changes by committing this now.
|
Oops... made changes to wrong PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help address #357
There is also vertex light support with #382
Experimental support for pixel lights. Pixel lights can be point, spot or directional lights which are set to Important or in some cases Automatic.
Point Light
Spot Light
About
This is a very rough PR. It will need a lot of work.
Pass and Blending
Adds another pass and uses
BlendOp Max. This prevents the more egregious artefacts. Improving the extra pass is a better way to go. Distilling the pass to only perform the necessary work for the light itself is the ideal.Performance
Only the tiles which are affected by the light will require additional passes. Performance will depend on how many lights and their coverage. Performance can be improved by removing unnecessary work.
Issues
Plenty. I haven't properly worked through everything so some features are broken or misused.
Technical Debt
In its current form, technical debt is pretty high.
Directional Light
Based on light direction rather than camera to light for spot lights.