Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIRP Lighting #1073

Closed
Revmatek opened this issue Oct 5, 2022 · 0 comments
Closed

BIRP Lighting #1073

Revmatek opened this issue Oct 5, 2022 · 0 comments

Comments

@Revmatek
Copy link

Revmatek commented Oct 5, 2022

https://crest.readthedocs.io/en/latest/user/configuration.html?rp=birp

Crest BIRP does not support additional lights due to bugs in the pipeline and performance concerns. Please see #382 and #383 for more details.

Early on when I was evaluating which to use this, LUX, various other time savers, Lighting was one of the deal breakers (for right or wrong). At some point I evaluated Aura 2 and modified the Ocean.shader to have custom pass that adds volumetric lighting which at the time was a compromise for no light component support at all, other than directional lighting. This came at the cost of performance obviously but it was a desired trade off, something the user can turn off in settings for lower end machines, now I am no longer using Aura 2 due to unrelated reasons / requirements, but it proved to me it was possible to have a good lighting feature for this. At the time I also saw the 2 experimental branches that added lighting and I understood the concerns. But why not have this as a toggleable feature? Experimental? Is there still a show stopping bug? There must be some sort of workaround because it seems to work fluidly for similar projects some examples that do not meet my needs for other reasons but prove to me it is an obtainable goal:
https://youtu.be/uiEgukNGxrA (point-light)
https://youtu.be/1zx2hFxH7BI (spot-lights)

There are some other examples for URP, but I am not concerned about that.

Planar reflections works great and has a noticeable performance hit (which is expected), I think it would be totally acceptable to have additional lights in a similar manner. I tried briefly to adapt the branches to the current baselines but did not have the time to proceed to a satisfactory level. The screenshots I saw would have been more than satisfactory for my use case, especially if it could be turned off when not needed. Some of the other time saving ocean / water projects out there (lacking many features) support lighting in this manner (or at least assert to). Is this something that can be put on a roadmap / future plan? I really feel like if Crest supported additional lighting there would be little reason to use anything else in most cases baring uses that required no more than a puddle of water or a pond you can't actually swim in but is more for scenic purposes, namely a functional ocean / body of water.

@wave-harmonic wave-harmonic locked and limited conversation to collaborators Oct 6, 2022
@daleeidd daleeidd converted this issue into discussion #1074 Oct 6, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant