Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed host_core release to copy musl nif #454

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Changed host_core release to copy musl nif #454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e55053
changed host_core release to copy musl nif
brooksmtownsend Aug 31, 2022
71847a3
added x86 musl nif build
brooksmtownsend Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
matrix:
target:
- x86_64-unknown-linux-gnu
- x86_64-unknown-linux-musl
- aarch64-unknown-linux-gnu
- aarch64-unknown-linux-musl
- x86_64-apple-darwin
Expand Down Expand Up @@ -192,12 +193,12 @@ jobs:
- uses: actions/download-artifact@v3
with:
path: ./host_core/priv/built/x86_64
name: x86_64-unknown-linux-gnu
name: x86_64-unknown-linux-musl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be gnu?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is just used for the docker image which is an alpine based image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mix release for x86 host_core still will use the gnu

# Download the NIF in the path that Docker expects for aarch64
- uses: actions/download-artifact@v3
with:
path: ./host_core/priv/built/aarch64
name: aarch64-unknown-linux-gnu
name: aarch64-unknown-linux-musl

- name: Login to AzureCR
uses: azure/docker-login@v1
Expand Down