Changed host_core release to copy musl nif #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
stevelr
as code owners
Signed-off-by: Brooks Townsend <[email protected]>
| @@ -192,12 +193,12 @@ jobs: | |||
| - uses: actions/download-artifact@v3 | |||
| with: | |||
| path: ./host_core/priv/built/x86_64 | |||
| name: x86_64-unknown-linux-gnu | |||
| name: x86_64-unknown-linux-musl | |||
There was a problem hiding this comment.
Should this still be gnu?
There was a problem hiding this comment.
No, this is just used for the docker image which is an alpine based image
There was a problem hiding this comment.
The mix release for x86 host_core still will use the gnu
thomastaylor312
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the action correct in #451 , but copied the wrong NIF