Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve permalinks - Issue #167 #168

Merged
merged 1 commit into from
May 8, 2024

Conversation

melnikga
Copy link
Contributor

@melnikga melnikga commented May 7, 2024

#167
The problem was solely related to the telegram application on macbooks downloaded from the App store. The decision took a lot more effort than I expected. In the end, I figured out what the problem was, in this case, telegram very selectively allows you to insert links with base64 encoding, so standard methods like btoa() and encodeURIComponent() will not work here. The LZString library came to the rescue with its compressToEncodedURIComponent method, the encoding of which allows you to correctly insert links both in telegram on windows and in telegram on macbooks.

I also added DebugMode to the links, there was no difficulty with that.

@mazurroman mazurroman linked an issue May 7, 2024 that may be closed by this pull request
@mazurroman mazurroman self-requested a review May 8, 2024 09:07
Copy link
Contributor

@mazurroman mazurroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mazurroman mazurroman merged commit cc467a5 into walnuthq:main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Improve permalinks
2 participants