Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use systemctl json output to build up fact for internal services #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −7
Open

feat: use systemctl json output to build up fact for internal services #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions lib/facter/systemd.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,10 @@
end

Facter.add(:systemd_internal_services) do
require 'json'
confine systemd: true
setcode do
command_output = Facter::Util::Resolution.exec(
'systemctl list-unit-files --no-legend --no-pager "systemd-*" -t service --state=enabled,disabled,enabled-runtime,indirect'
)
lines = command_output.lines.lazy.map { |line| line.split(%r{\s+}) }
lines.each_with_object({}) do |(service, status, *), result|
result[service] = status
end
command_output = Facter::Util::Resolution.exec('systemctl list-unit-files "systemd-*" -t service --state=enabled,disabled,enabled-runtime,indirect -o json')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't use it in the past because not all systemctl versions support the option. Do you know when the option was introduced?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can add an acceptance test 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google told me: version 239 (May 2017). maybe i drop this PR. if we still have to support older systemds the more "hacky" version was a better approach for this 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may i wait until the older osses are dropped 😆
#496

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EL8 will not be dropped with that patch and EOL for EL8 is 2029.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah damnit okay... then i think i drop it for the moment. the current implementation is working for older and newer versions of systemd. didnt know the feature is this "new" 😆

JSON.parse(command_output).to_h { |service| [service['unit_file'], service['state']] }
end
end
Loading