feat: use systemctl json output to build up fact for internal services #499
Conversation
|
Certainly on EL8 the json option does nothing good: |
|
hmpf, damnit :( |
|
okay, this feature comes in with version 239 (May 2017) |
| lines.each_with_object({}) do |(service, status, *), result| | ||
| result[service] = status | ||
| end | ||
| command_output = Facter::Util::Resolution.exec('systemctl list-unit-files "systemd-*" -t service --state=enabled,disabled,enabled-runtime,indirect -o json') |
There was a problem hiding this comment.
I didn't use it in the past because not all systemctl versions support the option. Do you know when the option was introduced?
There was a problem hiding this comment.
Or we can add an acceptance test 🤔
There was a problem hiding this comment.
google told me: version 239 (May 2017). maybe i drop this PR. if we still have to support older systemds the more "hacky" version was a better approach for this 🤔
There was a problem hiding this comment.
may i wait until the older osses are dropped 😆
#496
There was a problem hiding this comment.
EL8 will not be dropped with that patch and EOL for EL8 is 2029.
There was a problem hiding this comment.
ah damnit okay... then i think i drop it for the moment. the current implementation is working for older and newer versions of systemd. didnt know the feature is this "new" 😆
It's documented as working in EL8. I'll report it as a bug to Redhat. Maybe it will get fixed. |
No description provided.