Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile: Allow Puppet 7 and 8 #925

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

moduleroot/Gemfile.erb Outdated Show resolved Hide resolved
@bastelfreak
Copy link
Member Author

tested at voxpupuli/puppet-example#74 and locally:

bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-zabbix $ git diff
diff --git a/Gemfile b/Gemfile
index fef90ee..89b2311 100644
--- a/Gemfile
+++ b/Gemfile
@@ -28,7 +28,7 @@ end
 gem 'rake', :require => false
 gem 'facter', ENV['FACTER_GEM_VERSION'], :require => false, :groups => [:test]

-puppetversion = ENV['PUPPET_GEM_VERSION'] || '~> 7.24'
+puppetversion = ENV['PUPPET_GEM_VERSION'] || ['>= 7.24', '< 9']
 gem 'puppet', puppetversion, :require => false, :groups => [:test]

 # vim: syntax=ruby
bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-zabbix $ bundle update
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Fetching getoptlong 0.2.1
Fetching fast_gettext 3.1.0 (was 2.4.0)
Installing getoptlong 0.2.1
Installing fast_gettext 3.1.0 (was 2.4.0)
Fetching puppet 8.8.1 (was 7.32.1)
Installing puppet 8.8.1 (was 7.32.1)
Bundle updated!
bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-zabbix $ bundle clean
Removing fast_gettext (2.4.0)
Removing hiera (3.12.0)
Removing puppet (7.32.1)
bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-zabbix $ bundle outdated
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...

Gem             Current  Latest  Requested  Groups
http            2.2.2    5.2.0
http-accept     1.7.0    2.2.1
http-form_data  1.0.3    2.3.0
http_parser.rb  0.6.0    0.8.0
minitar         0.12.1   1.0.2
octokit         4.25.1   9.1.0
pathspec        1.1.3    2.1.0
rubocop         1.50.2   1.66.1
rubocop-rspec   2.20.0   3.0.4
simplecov       0.16.1   0.22.0
simplecov-html  0.10.2   0.12.3
thor            1.2.2    1.3.2
yard            0.9.36   0.9.37
bastelfreak@bastelfreak-nb ~/code/modulesync_config/modules/voxpupuli/puppet-zabbix $

@bastelfreak
Copy link
Member Author

looks good now:

puppetversion = ENV['PUPPET_GEM_VERSION'] || [">= 7.24", "< 9"]
$ bundle info puppet
  * puppet (8.9.0)
	Summary: Puppet, an automated configuration management tool
	Homepage: https://github.com/puppetlabs/puppet
	Path: /home/bastelfreak/code/modulesync_config/modules/voxpupuli/puppet-example/.vendor/ruby/3.2.0/gems/puppet-8.9.0
	Reverse Dependencies:
		puppet-syntax (4.1.1) depends on puppet (>= 7, < 9)
		rspec-puppet-facts (5.1.0) depends on puppet (>= 7, < 9)
		rspec-puppet-utils (3.4.0) depends on puppet (>= 0)

@bastelfreak bastelfreak merged commit 9e31190 into voxpupuli:master Sep 13, 2024
4 checks passed
@bastelfreak bastelfreak deleted the version branch September 13, 2024 10:24
jhoblitt added a commit to jhoblitt/gha-puppet that referenced this pull request Sep 16, 2024
Resolves this error:

  /opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/3.2.0/bundler/resolver.rb:304:in `raise_not_found!': Could not find gem 'puppet (~> 7.0)' in locally installed gems. (Bundler::GemNotFound)

This appears to have been caused by this change:

  voxpupuli/modulesync_config#925

Which allows the version of puppet installed in the bundle to be >= 8.
jhoblitt added a commit to jhoblitt/gha-puppet that referenced this pull request Sep 16, 2024
Resolves this error:

    /opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/3.2.0/bundler/resolver.rb:304:in `raise_not_found!': Could not find gem 'puppet (~> 7.0)' in locally installed gems. (Bundler::GemNotFound)

This appears to have been caused by this change:

    voxpupuli/modulesync_config#925

Which allows the version of puppet installed in the bundle to be >= 8.
jhoblitt added a commit to jhoblitt/gha-puppet that referenced this pull request Sep 16, 2024
Resolves this error:

    /opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/3.2.0/bundler/resolver.rb:304:in `raise_not_found!': Could not find gem 'puppet (~> 7.0)' in locally installed gems. (Bundler::GemNotFound)

This appears to have been caused by this change:

voxpupuli/modulesync_config#925

Which allows the version of puppet installed in the bundle to be >= 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants