fix compat. with modulesync_config 9.2.0; rm PUPPET_GEM_VERSION #65
Conversation
Resolves this error:
/opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/3.2.0/bundler/resolver.rb:304:in `raise_not_found!': Could not find gem 'puppet (~> 7.0)' in locally installed gems. (Bundler::GemNotFound)
This appears to have been caused by this change:
voxpupuli/modulesync_config#925
Which allows the version of puppet installed in the bundle to be >= 8.
| @@ -48,5 +48,4 @@ jobs: | |||
| # https://docs.github.com/en/free-pro-team@latest/actions/reference/encrypted-secrets | |||
| BLACKSMITH_FORGE_USERNAME: '${{ secrets.username }}' | |||
| BLACKSMITH_FORGE_API_KEY: '${{ secrets.api_key }}' | |||
| PUPPET_GEM_VERSION: "~> 7.0" | |||
There was a problem hiding this comment.
We should have always set this on a higher level, around line 25 so it also affects the ruby/setup-ruby actions. I consider that a bug in the previous implementation.
There was a problem hiding this comment.
It feels kind of like a single source of truth violation to set a value in the release workflow which might conflict with the module's default. I agree that if the puppet gem version is to be explicitly declared in this workflow that it needs to be done prior to the bundle being installed.
The other position one could take is that modulesync_config is tightly coupled to this repo and changes to the Gemfile template require a new major version branch in this repo.
There was a problem hiding this comment.
Yes, but then it's duplicating info. It was as a workaround when Puppet 8 had issues
There was a problem hiding this comment.
My preference is [obviously] that we don't declare the gem version in this workflow.
Note that I am unable to merge in this repo.
Resolves this error:
This appears to have been caused by this change:
voxpupuli/modulesync_config#925
Which allows the version of puppet installed in the bundle to be >= 8.