🌱 Minimum version selection #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/mvs
branch
3 times, most recently
from
056b284 to
0369986
Compare
zyiyi11
approved these changes
Nov 7, 2024
bryanv
approved these changes
Nov 7, 2024
This patch updates all of the go.mod files in this repository, *other than the one for building the manager binary*, to specify the minimum required version of Go and minimum required versions for dependencies. This change allows downstream consumers of things like VM Op's API module to use a version of Go older than the one used by this repo. It turns out that Go 1.21 changed the meaning of the Go version in go.mod. Prior to 1.21, the version of Go in go.mod was informational. With Go 1.21 and after, it's required. That means if someone depends on VM Op's API module, and the module specifies Go 1.23.2, then the project depending on us requires 1.23.2. Of course our main binary still specifies the latest Go version and newest dependencies for handling CVEs. However, our sub-modules that are made to be pulled into *other* targets, such as our own manager, have no reason to specify the latest version of Go or dependencies.
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch updates all of the go.mod files in this repository, other than the one for building the manager binary, to specify the minimum required version of Go and minimum required versions for dependencies.
This change allows downstream consumers of things like VM Op's API module to use a version of Go older than the one used by this repo. It turns out that Go 1.21 changed the meaning of the Go version in
go.mod:Prior to 1.21, the version of Go in go.mod was informational. With Go 1.21 and after, it's required. That means if someone depends on VM Op's API module, and the module specifies Go 1.23.2, then the project depending on us requires 1.23.2.
Of course our main binary still specifies the latest Go version and newest dependencies for handling CVEs. However, our sub-modules that are made to be pulled into other targets, such as our own manager, have no reason to specify the latest version of Go or dependencies.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
cc @prziborowski
Please add a release note if necessary: