🐛 Use API Server DNS Names by default when logging into VM Web Console #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
4 times, most recently
from
4296bf1 to
60882f1
Compare
github-actions
bot
added
size/XL
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
from
cdb36ef to
4f4742b
Compare
ammujumdar-bcom
changed the title
sreyasn
reviewed
Oct 18, 2024
controllers/virtualmachinewebconsolerequest/v1alpha2/webconsolerequest_controller.go
Outdated
Show resolved
Hide resolved
sreyasn
reviewed
Oct 18, 2024
controllers/virtualmachinewebconsolerequest/v1alpha1/webconsolerequest_controller.go
Outdated
Show resolved
Hide resolved
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
from
641051a to
374470e
Compare
dilyar85
requested changes
Oct 22, 2024
controllers/virtualmachinewebconsolerequest/v1alpha1/webconsolerequest_unit_test.go
Outdated
Show resolved
Hide resolved
bryanv
reviewed
Oct 23, 2024
controllers/virtualmachinewebconsolerequest/v1alpha1/webconsolerequest_unit_test.go
Outdated
Show resolved
Hide resolved
controllers/virtualmachinewebconsolerequest/v1alpha2/webconsolerequest_controller.go
Outdated
Show resolved
Hide resolved
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
4 times, most recently
from
e2427d1 to
6378df7
Compare
sreyasn
requested changes
Nov 6, 2024
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
from
ce10654 to
12f6340
Compare
sreyasn
approved these changes
Nov 7, 2024
dilyar85
requested changes
Nov 8, 2024
controllers/virtualmachinewebconsolerequest/v1alpha1/webconsolerequest_controller.go
Outdated
Show resolved
Hide resolved
controllers/virtualmachinewebconsolerequest/v1alpha1/webconsolerequest_intg_test.go
Outdated
Show resolved
Hide resolved
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
2 times, most recently
from
558b911 to
5763b6c
Compare
In certain environments, a load balancer, and therefore a virtual IP, may not be present. In these cases, rather than relying on the virtual IP to log into the VM web console, we need to instead rely on an FQDN / DNS name to login. This change plumbs the API Server DNS Names from the app platform CRD, and uses that by default to login to the VM Web Console. If no DNS Name is found, then we fall back to the previous method of using the virtual IP to login. Testing Done: Used an existing testbed - note that this setup has a load balancer already Setup steps: Deployed a VM named my-vm on test-namespace On control plane VM, changed /usr/lib/vmware-wcp/objects/PodVM-GuestCluster/30-vmop/vmop.yaml file to add rbac permissions for appplatform (since vmop tar won't load those changes) and re-applied yaml Loaded vmop tar image using make docker-build, docker save docker.io/library/vmoperator-controller:latest > vmopfqdn.tar, and deploy-wcp.sh Next, verified that web console returns API Server DNS name for login: root@localhost [ ~ ]# kubectl vsphere vm web-console my-vm -n test-namespace Successfully created a new WebConsoleRequest 'my-vm-b498r' in namespace 'test-namespace' Waiting for the above WebConsoleRequest to be processed... Web-Console URL: https://domain-1.test/vm/web-console?host=10.167.71.251&namespace=test-namespace&port=443&ticket=36fcf5b74000d104f4b3a5038381326f&uuid=77c1da1f-dbea-4bc2-af55-78303afc21d4 This URL is for one-time use and will expire at 2024-10-17T22:12:56Z (in about 2m0s)
ammujumdar-bcom
force-pushed
the
topic/ammujumdar/use-fqdn-if-given
branch
from
5763b6c to
356a13e
Compare
dilyar85
approved these changes
Nov 8, 2024
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
In certain environments, a load balancer, and therefore a virtual IP, may not be present. In these cases, rather than relying on the virtual IP to log into the VM web console, we need to instead rely on an FQDN / DNS name to login.
This change plumbs the API Server DNS Names from the app platform CRD, and uses that by default to login to the VM Web Console. If no DNS Name is found, then we fall back to the previous method of using the virtual IP to login.
Testing Done:
Used an existing testbed - note that this setup has a load balancer already
Setup steps:
my-vmontest-namespace/usr/lib/vmware-wcp/objects/PodVM-GuestCluster/30-vmop/vmop.yamlfile to add rbac permissions for appplatform (since vmop tar won't load those changes) and re-applied yamlmake docker-build,docker save docker.io/library/vmoperator-controller:latest > vmopfqdn.tar, anddeploy-wcp.shNext, verified that web console returns API Server DNS name for login:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: