✨ Adds minimum hardware version to VirtualMachine CRD #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing-needed-e2e-fast
size/L
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
2 times, most recently
from
9df30a3 to
12ee8d3
Compare
srm09
changed the title
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
from
12ee8d3 to
a3b84e7
Compare
srm09
added
testing-done-e2e-fast
bryanv
reviewed
Aug 22, 2023
pkg/vmprovider/providers/vsphere/session/session_vm_update_test.go
Outdated
Show resolved
Hide resolved
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
2 times, most recently
from
4f599f0 to
fa1d625
Compare
sreyasn
reviewed
Sep 19, 2023
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
from
fa1d625 to
5faeb07
Compare
|
Waiting on the v1a2 work to be brought to a stable state before introducing more API changes, work has been completed for now. |
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
2 times, most recently
from
ef1ce0e to
2c8463e
Compare
sreyasn
reviewed
Nov 7, 2023
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
from
2c8463e to
0ad01d5
Compare
sreyasn
reviewed
Nov 9, 2023
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
from
0ad01d5 to
cbcfcee
Compare
Introduces a new field on the VirtualMachine CRD which allows the user to define the minimum hardware version for the provisioned VM. The behavior of the field is as follows: - If the VMClassAsConfig FSS is enabled, it will override the hardware version derived from the VMClass's ConfigSpec if it is lower than the minimum version field. Otherwise, the value from the ConfigSpec is honored. - If the VMClassAsConfig FSS is disabled, it will reconfigure the VM post creation before the power on operation to ensure that the h/w version is atleast set to the minimum version. This means, it can override the hardware version of the OVA with a hardware version value lower than this field. Signed-off-by: Sagar Muchhal <[email protected]>
srm09
force-pushed
the
vm-api-change/add-min-hw-version
branch
from
cbcfcee to
1853fb5
Compare
Minimum allowed line rate is |
sreyasn
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Introduces a new field on the VirtualMachine CRD which allows the user to define the minimum hardware version for the provisioned VM. The behavior of the field is as follows:
Which issue(s) is/are addressed by this PR? :
Fixes #151
Are there any special notes for your reviewer:
Testing performed:
Please add a release note if necessary: