Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose minimum hardware version on the VSphereVM spec #2212

Closed
srm09 opened this issue Aug 14, 2023 · 6 comments · Fixed by #2509
Closed

Expose minimum hardware version on the VSphereVM spec #2212

srm09 opened this issue Aug 14, 2023 · 6 comments · Fixed by #2509
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@srm09
Copy link
Contributor

srm09 commented Aug 14, 2023

/kind feature

Describe the solution you'd like
Similar to the hardware version field on the infrastructure.cluster.x-k8s.io VSphereVM API types, we'd like to introduce a similar field on the API types under the vmware.infrastructure.cluster.x-k8s.io API group as well.

Anything else you would like to add:
With some recent updates to the underlying VMOperator provisioner used in vCenter Workload Management, the hardware version of the VirtualMachine now gets inferred from the VMClass instead of being calculated from the hardware version set in the OVA. If the hardware version is not set on the VMClass, then it defaults to the vCenter datacenter/cluster/host compatibility version defaults.
Since hardware version dictates the hardware compatibility of VMs, CAPV users should have the ability to be able to prescribe the minimum hardware version that a VM should adhere to.

This would require pulling in the updated VMOp APIs which expose setting this field on the Spec.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 14, 2023
@sbueringer
Copy link
Member

sbueringer commented Aug 14, 2023

Sounds good!

Wait, does this mean we have to start using v1alpha2?

@chrischdi
Copy link
Member

chrischdi commented Aug 16, 2023

I think its not even part of v1alpha2. I was only able to find it for the VirtualMachineImage object in v1alpha2:

https://github.com/vmware-tanzu/vm-operator/blob/main/api/v1alpha1/virtualmachineimage_types.go#L103

@sbueringer sbueringer added the triage/needs-information Indicates an issue needs more information in order to work on it. label Aug 18, 2023
@srm09
Copy link
Contributor Author

srm09 commented Nov 15, 2023

/retitle Expose minimum hardware version on the VSphereVM spec

@k8s-ci-robot k8s-ci-robot changed the title Adds a new hardware version field to the VSphereVM Spec Expose minimum hardware version on the VSphereVM spec Nov 15, 2023
@srm09
Copy link
Contributor Author

srm09 commented Nov 15, 2023

VM-operator vmware-tanzu/vm-operator#205 exposes a new field to set the minimum h/w version on the VirtualMachine Spec. This issue is to track the uptake of this field in the VSphereVM spec in the vmware.infra.cluster.x-k8s.io API group.

@srm09
Copy link
Contributor Author

srm09 commented Nov 15, 2023

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 15, 2023
@srm09
Copy link
Contributor Author

srm09 commented Nov 15, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants