Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build CLI for Windows ARM64 #610

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Build CLI for Windows ARM64 #610

merged 1 commit into from
Dec 15, 2023

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

With Windows 11 supporting AMD64 (x86) emulation out-of-the-box it becomes possible to run AMD64 plugins on a Windows 11 ARM64 machine.

As a first step, this simple PR starts building the CLI for the Windows ARM64 platform.

Which issue(s) this PR fixes

Part of #357

Describe testing done for PR

$ make cross-build
build linux-amd64 CLI with version: v1.2.0-dev
build windows-amd64 CLI with version: v1.2.0-dev
build darwin-amd64 CLI with version: v1.2.0-dev
build linux-arm64 CLI with version: v1.2.0-dev
build windows-arm64 CLI with version: v1.2.0-dev
build darwin-arm64 CLI with version: v1.2.0-dev
[...]

$ file artifacts/windows/arm64/cli/core/v1.2.0-dev/tanzu-cli-windows_arm64.exe
artifacts/windows/arm64/cli/core/v1.2.0-dev/tanzu-cli-windows_arm64.exe: PE32+ executable (console) Aarch64, for MS Windows
$ file artifacts/windows/amd64/cli/core/v1.2.0-dev/tanzu-cli-windows_amd64.exe
artifacts/windows/amd64/cli/core/v1.2.0-dev/tanzu-cli-windows_amd64.exe: PE32+ executable (console) x86-64, for MS Windows

I also downloaded the binary on a Windows 11 ARM64 machine on Azure and confirmed that it ran.
On Azure I used a Windows 11 ARM64 image on a D2ps CPU

Release note

Allow building the CLI for Windows ARM64.

Additional information

Special notes for your reviewer

@marckhouzam marckhouzam requested a review from a team as a code owner December 8, 2023 20:10
@marckhouzam
Build CLI for Windows ARM64
bc30474 
With Windows 11 supporting AMD64 (x86) emulation out-of-the-box it
becomes possible to run AMD64 plugins on a Windows 11 ARM64 machine.

As a first step, this commit starts building the CLI for the
Windows ARM64 platform.

Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam mentioned this pull request Dec 9, 2023
Merged
@marckhouzam marckhouzam added this to the v1.2.0 milestone Dec 11, 2023
@marckhouzam marckhouzam added the kind/feature Categorizes issue or PR as related to a new feature label Dec 11, 2023
@marckhouzam marckhouzam force-pushed the feat/buildCLIWinArm64 branch from 8d35f43 to bc30474 Compare December 15, 2023 02:47
@marckhouzam marckhouzam mentioned this pull request Dec 15, 2023
Merged
prkalle
prkalle approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@prkalle prkalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@marckhouzam marckhouzam merged commit 4d4e7cc into vmware-tanzu:main Dec 15, 2023
7 checks passed
@marckhouzam marckhouzam deleted the feat/buildCLIWinArm64 branch December 15, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prkalle prkalle prkalle approved these changes

Assignees
No one assigned
Labels
cla-not-required kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marckhouzam @prkalle @vmwclabot