Build plugins for Windows ARM64 #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckhouzam
added
the
kind/feature
anujc25
approved these changes
Dec 21, 2023
| @@ -36,7 +36,7 @@ PLUGIN_DEBUG=false | |||
| endif | |||
|
|
|||
| # Add supported OS-ARCHITECTURE combinations here | |||
| PLUGIN_BUILD_OS_ARCH ?= linux-amd64 windows-amd64 darwin-amd64 darwin-arm64 linux-arm64 | |||
| PLUGIN_BUILD_OS_ARCH ?= linux-amd64 windows-amd64 darwin-amd64 linux-arm64 darwin-arm64 windows-arm64 | |||
There was a problem hiding this comment.
Considering we are adding the linux-arm64 as well, should we mention linux-arm64 in the PR description as well?
There was a problem hiding this comment.
Sorry for the confusion, I just reordered the list so it was consistent: linux-arm64 was already there, just in a different order.
We start building the 'builder' and 'test' plugins for Windows ARM64. We also default new plugin projects to also building for Windows ARM64. The builder plugin will publish the Windows ARM64 binaries and include them in the plugin inventory DB if they are present. If they are not present, the builder plugin will ignore them with a printout as is done for the other two ARM64 builds. Signed-off-by: Marc Khouzam <[email protected]>
marckhouzam
force-pushed
the
feat/publishWinArm64
branch
from
9f0470b to
20d0b50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
We start building the 'builder' and 'test' plugins for Windows ARM64.
We also default new plugin projects to also building for Windows ARM64.
The builder plugin will publish the Windows ARM64 binaries and include them in the plugin inventory DB if they are present. If they are not present, the builder plugin will ignore them with a printout as is done for the other two ARM64 builds.
Which issue(s) this PR fixes
Part of #357
Describe testing done for PR
Building and publish the builder and test plugins for all osarch (including Windows ARM64):
Making sure a plugin can build and publish WITHOUT the new Windows ARM64.
I removed the string
windows-arm64from the plugin-tooling.mk file.Notice above the message
ignoring unavailable plugin for optional os/arch: windows_arm64which is expected since we did not build the plugin for that OS/ARCH.Check when just doing validation after building all osarch, including Windows ARM64:
I also checked when just doing validation after building as above but WITHOUT the new Windows ARM64.
I first removed the string
windows-arm64from theplugin-tooling.mkfile.I confirm it works.
Test creating a new plugin to see that Windows ARM64 is built by default:
And finally, I uploaded the Windows ARM64 CLI binary and the
artifacts/plugins/windows/arm64directory to an ARM64 Windows machine on Azure and was able to install and run both thebuilderandtestplugins.Release note
Additional information
Special notes for your reviewer