Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move s:viml_builtin_functions to s:VimLParser.builtin_functions #125

Merged
merged 5 commits into from
Jul 25, 2019
Merged

Move s:viml_builtin_functions to s:VimLParser.builtin_functions #125

merged 5 commits into from
Jul 25, 2019

Conversation

tyru
Copy link
Member

@tyru tyru commented Jul 19, 2019

Fix #118

@tyru tyru force-pushed the move-builtin-funcs-to-viml branch from 40cf5ff to 1ea6512 Compare July 19, 2019 18:19
@tyru
Copy link
Member Author

tyru commented Jul 24, 2019

@blueyed thanks for review!
@mattn to make sure, please review this

@tyru tyru requested a review from mattn July 24, 2019 11:45
@tyru tyru mentioned this pull request Jul 24, 2019
Merged
3 tasks
@mattn
Copy link
Member

mattn commented Jul 25, 2019

LGTM～

@mattn mattn merged commit 5965112 into master Jul 25, 2019
@mattn
Copy link
Member

mattn commented Jul 25, 2019

Thanks!

@mattn mattn deleted the move-builtin-funcs-to-viml branch July 25, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattn mattn mattn left review comments

@blueyed blueyed blueyed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move s:viml_builtin_functions to shared file?
3 participants
@tyru @mattn @blueyed