Make vimlparser.py (much more) PEP8 compliant

[blueyed]

TODO:

• rebase after
  • get_token_sq_c: skip char2nr for fixed values #121
  • Fix undefined variable 'token' #126

- [ ] integrate #132 / #131

[tyru]

Is there any chance to lint this in CI? 😎

[blueyed]

Sure.. :)

I am using the following config locally (which is OK for now I guess):

[flake8]
per-file-ignores =
    # undefined names for StringReader, VimLParser, Compiler
    py/vimlfunc.py:F821
    py/vimlparser.py:E501

With this PR it results in:

py/vimlparser.py:2192:79: F821 undefined name 'token'
py/vimlparser.py:2192:93: F821 undefined name 'token'
py/vimlparser.py:4249:46: W605 invalid escape sequence '\e'

(two real issues (#121, and #110 (review)))

[blueyed]

There you go: https://travis-ci.org/vim-jp/vim-vimlparser/jobs/561117833

[blueyed]

I think it's ready, but needs to be rebased after fixing the two issues mentioned above.

[blueyed]

Rebased.

[tyru]

maybe this change is conflicted to @mattn (and me?), so I can't merge this soon.

[blueyed]

maybe this change is conflicted to @mattn (and me?), so I can't merge this soon.

Sure, happy to rebase this later again.

[blueyed]

This should be fixed.

[blueyed]

Slightly better now, but has wrong indent.

[tyru]

integrate #132 / #131

Ah sorry, now I think I was requesting too much to @blueyed and it makes this PR bloated.
I think this should be in another PR.

After #119 and #125, please rebase master again 🙇
(But currently @mattn may be busy now because he is VimConf 2019 stuff... 😎 please hang tight)

[blueyed]

Ah sorry, now I think I was requesting too much to @blueyed and it makes this PR bloated.
I think this should be in another PR.

We can do it later.
I still think that we basically only need to run flake8 on the output (via Python 3) to be good, and that's done here already.

please hang tight

No worries, just let me know when it is a bit calmer, and I am happy to rebase it then.

[tyru]

No worries, just let me know when it is a bit calmer, and I am happy to rebase it then.

Now it's time to rebase 😎

[blueyed]

Rebased, should be good.
Feel free to squash - but I've added / kept existing "gen" steps to see what is being done.

[tyru]

Thank you 🎉🍺🎉

[blueyed]

You are welcome, glad to help! 🍻