Add proxy config for containerd and apt on ubuntu #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue: #258 |
|
@mnaser @okozachenko1203 Flatcar is fixed here now. Review comments welcome when you have time. |
okozachenko1203
previously approved these changes
Jan 23, 2024
|
Seems to fail locally: |
mnaser
reviewed
Mar 8, 2024
magnum_cluster_api/resources.py
Outdated
| }, | ||
| { | ||
| "op": "add", | ||
| "path": "/spec/template/spec/kubeadmConfigSpec/preKubeadmCommands/-", |
There was a problem hiding this comment.
Suggested change
| "path": "/spec/template/spec/kubeadmConfigSpec/preKubeadmCommands/-", | |
| "path": "/spec/template/spec/kubeadmConfigSpec/preKubeadmCommands/-", |
Maybe this shouldn't have the trailing /- ?
mnaser
approved these changes
Mar 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for HTTP proxy servers in user clusters, with config supplied via the existing Magnum proxy variables. Specifically, proxies are configured in containerd for image downloads, and in apt when running Ubuntu.
I've had to add a placeholder file to the KubeadmConfigTemplate as otherwise the JSON patch process fails when adding files to the empty array.